Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.stop() does not stop callbacks from being executed #28

darkargon opened this issue Jun 17, 2012 · 2 comments

.stop() does not stop callbacks from being executed #28

darkargon opened this issue Jun 17, 2012 · 2 comments


Copy link

without jquery++ :

It only does not work with this combination: animation -> delay/timeout -> stop() -> animation
the second animation will trigger the callback of the first one, even though .stop() was called.

( Sorry for my bad English)

Copy link

daffl commented Jun 18, 2012

I see the problem now. Have to check if it just executes the callback twice or doesn't remember not to call it.

Copy link

xpy commented Aug 24, 2012

I think the problem is when unbinding the animation handler in line 290

// Unbind the animation end handler, animationEnd);

as seen in line 311

    // Attach the transition end event handler to run only once, function() {
// Call animationEnd using the passed properties
animationEnd(props, true);

It was not bound with the 'animationEnd' function...

@daffl daffl closed this as completed in cf3ea63 Aug 29, 2012
asavoy pushed a commit to asavoy/jquerypp that referenced this issue Oct 21, 2013
Update link to master popcornjs repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

3 participants