Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.stop() does not stop callbacks from being executed #28

Closed
darkargon opened this issue Jun 17, 2012 · 2 comments
Closed

.stop() does not stop callbacks from being executed #28

darkargon opened this issue Jun 17, 2012 · 2 comments
Labels
bug

Comments

@darkargon
Copy link

@darkargon darkargon commented Jun 17, 2012

jsfiddle: http://jsfiddle.net/DarkArgon/7eDuT/4/
without jquery++ : http://jsfiddle.net/DarkArgon/4SQfJ/1/

It only does not work with this combination: animation -> delay/timeout -> stop() -> animation
the second animation will trigger the callback of the first one, even though .stop() was called.

( Sorry for my bad English)

@daffl
Copy link
Contributor

@daffl daffl commented Jun 18, 2012

I see the problem now. Have to check if it just executes the callback twice or doesn't remember not to call it.

@xpy
Copy link

@xpy xpy commented Aug 24, 2012

I think the problem is when unbinding the animation handler in line 290

// Unbind the animation end handler
self.off(getBrowser().transitionEnd, animationEnd);

as seen in line 311

    // Attach the transition end event handler to run only once
self.one(getBrowser().transitionEnd, function() {
// Call animationEnd using the passed properties
animationEnd(props, true);
done();
});

It was not bound with the 'animationEnd' function...

@daffl daffl closed this in cf3ea63 Aug 29, 2012
asavoy pushed a commit to asavoy/jquerypp that referenced this issue Oct 21, 2013
Update link to master popcornjs repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.