Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks in jQuery.noConflict(true) Scenario #67

Closed
jeffrose opened this issue Dec 13, 2012 · 4 comments
Closed

Breaks in jQuery.noConflict(true) Scenario #67

jeffrose opened this issue Dec 13, 2012 · 4 comments

Comments

@jeffrose
Copy link

@jeffrose jeffrose commented Dec 13, 2012

While the various modules are surrounded by...

define(['jquery', ...], function( $, ... ) {

... many of them make references to the global jQuery variable, which does not exist if jQuery.noConflict(true); has been called.

In general AMD modules should avoid accessing variables in the global scope.

@daffl
Copy link
Contributor

@daffl daffl commented Dec 13, 2012

Sounds familiar ;) I guess we'll have to go through it and just change everything to $.

@jeffrose
Copy link
Author

@jeffrose jeffrose commented Dec 13, 2012

At least it should be an easy fix. :-)

@jeffrose
Copy link
Author

@jeffrose jeffrose commented Dec 14, 2012

I assume this will be in the next release. Do you know when that will be?

@daffl
Copy link
Contributor

@daffl daffl commented Dec 14, 2012

I wanted to get out a patch version soon. A pull request would greatly speed up the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.