New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added width property to selection plugin. #11

Merged
merged 2 commits into from Jun 8, 2012

Conversation

Projects
None yet
2 participants
@callumacrae
Contributor

callumacrae commented Jun 7, 2012

Added a width property to the object returned by $(el).selection(). Doesn't have any significant performance impact, so can't see any harm in adding it.

I also rewrote the test, as it was randomly failing sometimes.

daffl added a commit that referenced this pull request Jun 8, 2012

Merge pull request #11 from callumacrae/selection-width
Added width property to selection plugin.

@daffl daffl merged commit 38a3d76 into bitovi:master Jun 8, 2012

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jun 8, 2012

Contributor

Awesome thanks! The width makes sense and the tests were actually failing before (don't know why it slipped through). All working now, will be in the next release.

Contributor

daffl commented Jun 8, 2012

Awesome thanks! The width makes sense and the tests were actually failing before (don't know why it slipped through). All working now, will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment