Force hover leave on new mouseenter. Fixes #63 and #64. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the mouse has entered a new element, this change forces the hoverleave event to fire on the previously hovered element, even if no mouseleave event fires. The mouseleave event will not fire if the element is removed while hovered and possibly in other circumstances.
|
Thanks! Looks good, but do you have an idea how to test this? I can probably merge it in and see if we can make some FuncUnit tests that cover it. |
|
Here's a demo of the problem: http://jsfiddle.net/qAFSX/3/ So, hover an element, verify it gets updated. Remove the hovered element and try to hover another element with the same class. It should update but doesn't without this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had some terrible problems with the hover plugin getting locked up and never initiating new hover events. This is really bad for our app because some critical controls only show on hover. THe only way to get them back was to reload the page. So we came up with a failsafe behavior.
If the mouse has entered a new element, this change forces the hoverleave event to fire on the previously hovered element (after the correct hover leave time), even if no mouseleave event fires.
The mouseleave event will not fire if the element is removed while hovered and possibly in other circumstances.