Fixing some imports issues with bwcTsMigration #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahriggan
commented
Aug 21, 2019
| @@ -4,8 +4,8 @@ | |||
| "author": "BitPay Inc", | |||
| "version": "8.6.0", | |||
| "license": "MIT", | |||
| "main": "ts_build/index.js", | |||
| "types": "./ts_build/index.d.ts", | |||
| "main": "./ts_build/index.js", | |||
There was a problem hiding this comment.
@justinkook remove these?
| }, | ||
| "scripts": { | ||
| "start": "npm run clean && npm run tsc && node app.js", | ||
| "coverage": "./node_modules/.bin/istanbul cover ./node_modules/.bin/_mocha -- --reporter spec test", | ||
| "test": "./node_modules/.bin/mocha --exit", | ||
| "test": "npm run compile && ./node_modules/.bin/mocha --exit", | ||
| "test:ci": "npm run test", | ||
| "docs": "./node_modules/.bin/jsdox lib/* lib/common lib/errors -o docs && cat README.header.md docs/*.md LICENSE > README.md", | ||
| "coveralls": "./node_modules/.bin/istanbul cover ./node_modules/mocha/bin/_mocha --report lcovonly -- -R spec && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage", |
There was a problem hiding this comment.
| export const Common = { Constants, Defaults, Utils }; | ||
| /* | ||
| *module.exports = { |
There was a problem hiding this comment.
Commented out code
rastajpa
approved these changes
Aug 21, 2019
justinkook
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't figure out how to submit this pr to your fork @Gamboster