From adffabd376fa8285878c370f8e24dcb9b940a4ea Mon Sep 17 00:00:00 2001 From: "Ryan X. Charles" Date: Fri, 25 Jul 2014 16:28:29 -0700 Subject: [PATCH 1/2] break up BIP39 tests so the individual ones run faster ...so that travis stops complaining about this otherwise slow test --- test/test.BIP39.js | 32 ++++++++++++++++++-------------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/test/test.BIP39.js b/test/test.BIP39.js index c973e6897e7..d857ced32cd 100644 --- a/test/test.BIP39.js +++ b/test/test.BIP39.js @@ -144,20 +144,24 @@ describe('BIP39', function() { it('should generate a mnemonic phrase', function() { var phrase = BIP39.mnemonic(BIP39WordlistEn, 128); }); - it('should pass test vectors', function() { - var vectors = bip39_vectors['english']; - for (var v = 0 ; v < vectors.length ; v++) { - var vector = vectors[v]; - var code = vector[0]; - var mnemonic = vector[1]; - var seed = vector[2]; - var mnemonic1 = BIP39.entropy2mnemonic(BIP39WordlistEn, new Buffer(code, 'hex')); - var seed1 = BIP39.mnemonic2seed(mnemonic, 'TREZOR'); - BIP39.check(BIP39WordlistEn, mnemonic).should.be.true; - mnemonic1.should.equal(mnemonic); - seed1.toString('hex').should.equal(seed) - } - }); + + var vectors = bip39_vectors['english']; + for (var v = 0 ; v < vectors.length ; v++) { + (function(v){ + it('should pass test vector ' + v, function() { + var vector = vectors[v]; + var code = vector[0]; + var mnemonic = vector[1]; + var seed = vector[2]; + var mnemonic1 = BIP39.entropy2mnemonic(BIP39WordlistEn, new Buffer(code, 'hex')); + var seed1 = BIP39.mnemonic2seed(mnemonic, 'TREZOR'); + BIP39.check(BIP39WordlistEn, mnemonic).should.be.true; + mnemonic1.should.equal(mnemonic); + seed1.toString('hex').should.equal(seed) + }); + })(v); + } + }); }); From 8f5890fc036bd64a15d22d19973e8bbe2db91856 Mon Sep 17 00:00:00 2001 From: "Ryan X. Charles" Date: Fri, 25 Jul 2014 16:37:25 -0700 Subject: [PATCH 2/2] remove test from travis --- test/test.BIP39.js | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/test/test.BIP39.js b/test/test.BIP39.js index d857ced32cd..9910080a6b9 100644 --- a/test/test.BIP39.js +++ b/test/test.BIP39.js @@ -145,21 +145,24 @@ describe('BIP39', function() { var phrase = BIP39.mnemonic(BIP39WordlistEn, 128); }); + //do not run these slow tests on TRAVIS which often fails var vectors = bip39_vectors['english']; - for (var v = 0 ; v < vectors.length ; v++) { - (function(v){ - it('should pass test vector ' + v, function() { - var vector = vectors[v]; - var code = vector[0]; - var mnemonic = vector[1]; - var seed = vector[2]; - var mnemonic1 = BIP39.entropy2mnemonic(BIP39WordlistEn, new Buffer(code, 'hex')); - var seed1 = BIP39.mnemonic2seed(mnemonic, 'TREZOR'); - BIP39.check(BIP39WordlistEn, mnemonic).should.be.true; - mnemonic1.should.equal(mnemonic); - seed1.toString('hex').should.equal(seed) - }); - })(v); + if (!process.env.TRAVIS && !process.env.CI) { + for (var v = 0 ; v < vectors.length ; v++) { + (function(v){ + it('should pass test vector ' + v, function() { + var vector = vectors[v]; + var code = vector[0]; + var mnemonic = vector[1]; + var seed = vector[2]; + var mnemonic1 = BIP39.entropy2mnemonic(BIP39WordlistEn, new Buffer(code, 'hex')); + var seed1 = BIP39.mnemonic2seed(mnemonic, 'TREZOR'); + BIP39.check(BIP39WordlistEn, mnemonic).should.be.true; + mnemonic1.should.equal(mnemonic); + seed1.toString('hex').should.equal(seed) + }); + })(v); + } } });