Skip to content
Permalink
Browse files

remove in-app-browser plugin and use externalLinkProvider, enable onl…

…y for BitPay
  • Loading branch information...
bsnowden3 committed Oct 17, 2019
1 parent 3537dfc commit c653365f1e0bfa8deadb0cbec578d08468304cdd
Showing with 5 additions and 9 deletions.
  1. +0 −1 package.json
  2. +1 −1 src/pages/settings/settings.html
  3. +3 −5 src/pages/settings/settings.ts
  4. +1 −2 tslint.json
@@ -102,7 +102,6 @@
"@ionic-native/core": "4.14.0",
"@ionic-native/device": "4.14.0",
"@ionic-native/file": "4.14.0",
"@ionic-native/in-app-browser": "4.14.0",
"@ionic-native/launch-review": "4.14.0",
"@ionic-native/qr-scanner": "4.14.0",
"@ionic-native/screen-orientation": "4.14.0",
@@ -1,6 +1,6 @@
<wide-header-page title="{{'Settings' | translate}}">
<div page-content>
<div class="no-padding hairline" no-padding detail-none>
<div *ngIf="appName === 'BitPay'" class="no-padding hairline" no-padding detail-none>
<div class="merchant-directory-container">
<div class="merchant-directory-body">
<h4>Learn where you can spend your crypto today.</h4>
@@ -17,7 +17,6 @@ import { ProfileProvider } from '../../providers/profile/profile';
import { TouchIdProvider } from '../../providers/touchid/touchid';

// pages
import { InAppBrowser } from '@ionic-native/in-app-browser/ngx';
import { AddPage } from '../add/add';
import { BitPayCardIntroPage } from '../integrations/bitpay-card/bitpay-card-intro/bitpay-card-intro';
import { BitPaySettingsPage } from '../integrations/bitpay-card/bitpay-settings/bitpay-settings';
@@ -73,7 +72,7 @@ export class SettingsPage {
private translate: TranslateService,
private modalCtrl: ModalController,
private touchid: TouchIdProvider,
private iab: InAppBrowser
private externalLinkProvder: ExternalLinkProvider
) {
this.appName = this.app.info.nameCase;
this.isCordova = this.platformProvider.isCordova;
@@ -156,9 +155,8 @@ export class SettingsPage {
}

public openMerchantDirectorySite() {
this.iab.create(
`https://bitpay.com/directory/?hideGiftCards=true`,
`_system`
this.externalLinkProvder.open(
`https://bitpay.com/directory/?hideGiftCards=true`
);
}

@@ -8,8 +8,7 @@
"rxjs",
"@angular",
"ts-md5/dist/md5",
"ionic-angular/gestures/gesture",
"@ionic-native/in-app-browser"
"ionic-angular/gestures/gesture"
],

// "no-any": true,

0 comments on commit c653365

Please sign in to comment.
You can’t perform that action at this time.