Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(desktop): Upgrade electron and electron-builder #10241

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@cmgustavo
Copy link
Member

cmgustavo commented Oct 15, 2019

  • Fix breaking changes.
  • Adds ethereum prefix support

electron-builder needs to be updated with this: electron-userland/electron-builder#4244

@cmgustavo cmgustavo changed the title chore(desktop): Upgrade electron and electron-builder WIP chore(desktop): Upgrade electron and electron-builder Oct 15, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #10241 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10241   +/-   ##
=======================================
  Coverage   44.27%   44.27%           
=======================================
  Files         171      171           
  Lines       15694    15694           
  Branches     2140     2140           
=======================================
  Hits         6948     6948           
  Misses       8330     8330           
  Partials      416      416
Impacted Files Coverage Δ
src/pages/integrations/coinbase/coinbase.ts 20.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6902d42...41542b3. Read the comment docs.

@cmgustavo cmgustavo force-pushed the cmgustavo:chore/electron-app-01 branch from f64db46 to f1c7726 Oct 17, 2019
@cmgustavo cmgustavo force-pushed the cmgustavo:chore/electron-app-01 branch from f1c7726 to a6ee682 Oct 29, 2019
@cmgustavo cmgustavo force-pushed the cmgustavo:chore/electron-app-01 branch from a6ee682 to 0d16ff0 Nov 4, 2019
@cmgustavo cmgustavo changed the title WIP chore(desktop): Upgrade electron and electron-builder chore(desktop): Upgrade electron and electron-builder Nov 4, 2019
Copy link
Contributor

rastajpa left a comment

ACK! it works good!

@matiu
matiu approved these changes Nov 8, 2019
@matiu matiu merged commit 5a7fb66 into bitpay:master Nov 8, 2019
4 checks passed
4 checks passed
ci/circleci: bitpay Your tests passed on CircleCI!
Details
ci/circleci: copay Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6902d42...41542b3
Details
codecov/project 44.27% remains the same compared to 6902d42
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.