Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better confetti performance on iOS upon gift card purchase #10473

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@msalcala11
Copy link
Collaborator

msalcala11 commented Jan 13, 2020

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #10473 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10473      +/-   ##
==========================================
+ Coverage   43.95%   43.95%   +<.01%     
==========================================
  Files         178      178              
  Lines       16409    16411       +2     
  Branches     2269     2269              
==========================================
+ Hits         7212     7213       +1     
- Misses       8747     8748       +1     
  Partials      450      450
Impacted Files Coverage Δ
...tegrations/gift-cards/card-details/card-details.ts 31.81% <33.33%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05726c7...049b4b3. Read the comment docs.

Copy link
Member

cmgustavo left a comment

LGTM

@cmgustavo cmgustavo merged commit 825f1dc into bitpay:master Jan 14, 2020
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 33.33% of diff hit (target 43.95%)
Details
ci/circleci: bitpay Your tests passed on CircleCI!
Details
ci/circleci: copay Your tests passed on CircleCI!
Details
codecov/project 43.95% (+<.01%) compared to 05726c7
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.