Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Send Page input to accept Copay BCH legacy address format #9175

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
3 participants
@Gamboster
Copy link
Collaborator

commented Sep 27, 2018

No description provided.

@codecov

This comment has been minimized.

Copy link

commented Sep 27, 2018

Codecov Report

Merging #9175 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9175      +/-   ##
==========================================
+ Coverage   38.41%   38.41%   +<.01%     
==========================================
  Files         163      163              
  Lines       14316    14315       -1     
  Branches     1895     1894       -1     
==========================================
  Hits         5499     5499              
  Misses       8553     8553              
+ Partials      264      263       -1
Impacted Files Coverage Δ
src/providers/address/address.ts 63.41% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a87607...a982381. Read the comment docs.

@van2009181435

This comment has been minimized.

Copy link

commented Sep 27, 2018

Javascript Node CircleCI 2.0 configuration file

Check https://circleci.com/docs/2.0/language-javascript/ for more details

version: 2
jobs:
copay:
docker:
- image: circleci/node@sha256:a6f4dfaae4e22f99d3910902362db706f32e0dbca7ce5ef757823d93fef1740e
working_directory: ~/copay
steps:
- checkout
# Download and cache dependencies
- restore_cache:
keys:
- v1-dependencies-{{ checksum "package.json" }}
# fallback to using the latest cache if no exact match is found
- v1-dependencies-
- run: npm install
- save_cache:
paths:
- node_modules
key: v1-dependencies-{{ checksum "package.json" }}
- run: npm run apply:copay
# Select correct Chromedriver version (this must run after npm install)
- run: npm run e2e:update-ci
- run: npm run test:lint
- run: npm run test:ci
- run: npm run e2e
- run: npx reg-cli test/visual/latest/copay test/visual/expected/copay test/visual/diffs --report test/visual/report.html --json test/visual/report.json --enableAntialias --pixelThreshold 20
- run: npx codecov
- store_artifacts:
path: ./test
- store_test_results:
path: ./test

bitpay:
docker:
- image: circleci/node@sha256:a6f4dfaae4e22f99d3910902362db706f32e0dbca7ce5ef757823d93fef1740e
working_directory: ~/copay
steps:
- checkout
- restore_cache:
keys:
- v1-dependencies-{{ checksum "package.json" }}
- v1-dependencies-
- run: npm install
- save_cache:
paths:
- node_modules
key: v1-dependencies-{{ checksum "package.json" }}
- run: npm run apply:bitpay
- run: npm run e2e:update-ci
- run: npm run test:lint
- run: npm run test:ci
- run: npm run e2e
- run: npx reg-cli test/visual/latest/bitpay test/visual/expected/bitpay test/visual/diffs --report test/visual/report.html --json test/visual/report.json --enableAntialias --pixelThreshold 20
- run: npx codecov
- store_artifacts:
path: ./test
- store_test_results:
path: ./test

workflows:
version: 2
build_and_test:
jobs:
- copay
- bitpay

@van2009181435

This comment has been minimized.

Copy link

commented Sep 27, 2018

hh

@van2009181435
Copy link

left a comment

dd

@van2009181435

This comment has been minimized.

Copy link

commented Sep 27, 2018

sd

@cmgustavo
Copy link
Member

left a comment

ACK

@cmgustavo cmgustavo merged commit 97786b5 into bitpay:master Sep 28, 2018

3 of 4 checks passed

codecov/patch 0% of diff hit (target 38.41%)
Details
ci/circleci: bitpay Your tests passed on CircleCI!
Details
ci/circleci: copay Your tests passed on CircleCI!
Details
codecov/project 38.41% (+<.01%) compared to 7a87607
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.