Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref: New backup flow #9561

Merged
merged 6 commits into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@Gamboster
Copy link
Collaborator

Gamboster commented Mar 6, 2019

This PR implements: New backup flow

  • Show each word instead the whole recovery phrase
  • Divide the actual backup game in two sections: backup key and backup game
  • Implement slides for the game
  • Remove the actual backup warning page
  • Implement new messages sheets
  • Replace all redirections to the new backup key page
  • Create a new style for finish modal

bitpay

bitpay

bitpay_y_bitpay

bitpay

bitpay

@Gamboster Gamboster force-pushed the Gamboster:ref/backupFlow branch from 32031af to cd08ccd Mar 6, 2019

Gamboster added some commits Mar 6, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #9561 into master will increase coverage by 0.01%.
The diff coverage is 27.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9561      +/-   ##
==========================================
+ Coverage    41.2%   41.21%   +0.01%     
==========================================
  Files         156      156              
  Lines       14262    14270       +8     
  Branches     1946     1938       -8     
==========================================
+ Hits         5876     5882       +6     
- Misses       8050     8052       +2     
  Partials      336      336
Impacted Files Coverage Δ
src/pages/finish/finish.ts 35.29% <ø> (ø) ⬆️
src/providers/action-sheet/action-sheet.ts 91.3% <ø> (ø) ⬆️
src/pages/backup/backup-game/backup-game.ts 18.69% <16.21%> (-0.32%) ⬇️
src/pages/backup/backup-key/backup-key.ts 30% <30%> (ø)
src/pages/receive/receive.ts 35.63% <50%> (ø) ⬆️
src/pages/wallet-details/wallet-details.ts 49.54% <50%> (ø) ⬆️
.../pages/settings/wallet-settings/wallet-settings.ts 33.03% <50%> (ø) ⬆️
src/pages/settings/settings.ts 32.29% <50%> (ø) ⬆️
.../pages/onboarding/backup-request/backup-request.ts 35.29% <50%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52820b3...3a67e4f. Read the comment docs.

Gamboster added some commits Mar 6, 2019

@Gamboster Gamboster force-pushed the Gamboster:ref/backupFlow branch from 755ee9d to 5ef5ba7 Mar 7, 2019

@Gamboster Gamboster changed the title WIP Ref: New backup flow Ref: New backup flow Mar 7, 2019

@Gamboster Gamboster force-pushed the Gamboster:ref/backupFlow branch from 5b91688 to 7053d20 Mar 7, 2019

@Gamboster Gamboster force-pushed the Gamboster:ref/backupFlow branch from 7053d20 to 3a67e4f Mar 7, 2019

@gabrielbazan7
Copy link
Collaborator

gabrielbazan7 left a comment

ACK

@gabrielbazan7 gabrielbazan7 merged commit ba5be56 into bitpay:master Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.