Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: electron/electron-builder and angular-cli/angular-devkit #9719

Merged

Conversation

Projects
None yet
3 participants
@cmgustavo
Copy link
Member

commented May 14, 2019

Updates:

@codecov

This comment has been minimized.

Copy link

commented May 14, 2019

Codecov Report

Merging #9719 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9719   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files         156      156           
  Lines       14210    14210           
  Branches     1954     1954           
=======================================
  Hits         5797     5797           
  Misses       8058     8058           
  Partials      355      355

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d145f00...7c2ee30. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented May 14, 2019

Codecov Report

Merging #9719 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9719   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files         156      156           
  Lines       14210    14210           
  Branches     1954     1954           
=======================================
  Hits         5797     5797           
  Misses       8058     8058           
  Partials      355      355

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d145f00...7c2ee30. Read the comment docs.

@@ -227,8 +227,8 @@
"zone.js": "0.8.26"
},
"devDependencies": {
"@angular-devkit/build-angular": "0.13.1",
"@angular/cli": "7.1.3",
"@angular-devkit/build-angular": "0.11.4",

This comment has been minimized.

Copy link
@Gamboster

Gamboster May 14, 2019

Collaborator

This dependency is downgrading. Is it ok?

This comment has been minimized.

Copy link
@cmgustavo

cmgustavo May 14, 2019

Author Member

Yes, check the released version and dependencies: https://github.com/angular/angular-cli/releases/tag/v7.1.4

@gabrielbazan7
Copy link
Collaborator

left a comment

ACK

@gabrielbazan7 gabrielbazan7 merged commit 8f4a3b4 into bitpay:master May 15, 2019

4 checks passed

ci/circleci: bitpay Your tests passed on CircleCI!
Details
ci/circleci: copay Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing d145f00...7c2ee30
Details
codecov/project 40.79% remains the same compared to d145f00
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.