Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pin-modal): keep countdown when app is running in background #9834

Merged
merged 2 commits into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@cmgustavo
Copy link
Member

commented Jun 11, 2019

No description provided.

@cmgustavo cmgustavo changed the title fix(pin-modal): remain countdown when app is running in background fix(pin-modal): keep countdown when app is running in background Jun 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #9834 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9834      +/-   ##
==========================================
- Coverage   46.29%   46.27%   -0.02%     
==========================================
  Files         159      159              
  Lines       14360    14366       +6     
  Branches     1981     1983       +2     
==========================================
  Hits         6648     6648              
- Misses       7289     7295       +6     
  Partials      423      423
Impacted Files Coverage Δ
src/pages/pin/pin-modal/pin-modal.ts 40.84% <0%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2e513...9e57523. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #9834 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9834      +/-   ##
==========================================
- Coverage   46.29%   46.27%   -0.03%     
==========================================
  Files         159      159              
  Lines       14360    14367       +7     
  Branches     1981     1983       +2     
==========================================
  Hits         6648     6648              
- Misses       7289     7296       +7     
  Partials      423      423
Impacted Files Coverage Δ
src/pages/pin/pin-modal/pin-modal.ts 40.55% <0%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2e513...62d7c2d. Read the comment docs.

@rastajpa
Copy link
Contributor

left a comment

ACK! nice work!

@gabrielbazan7
Copy link
Collaborator

left a comment

ACK

@gabrielbazan7 gabrielbazan7 merged commit 6370d79 into bitpay:master Jun 12, 2019

2 of 4 checks passed

codecov/patch 0% of diff hit (target 46.29%)
Details
codecov/project 46.27% (-0.03%) compared to 1b2e513
Details
ci/circleci: bitpay Your tests passed on CircleCI!
Details
ci/circleci: copay Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.