Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch a merge #14

Closed
emsesc opened this issue Jul 11, 2021 · 2 comments
Closed

Catch a merge #14

emsesc opened this issue Jul 11, 2021 · 2 comments

Comments

@emsesc
Copy link
Contributor

emsesc commented Jul 11, 2021

Stop a student from merging or closing an issue when they're not supposed to
@emsesc
Copy link
Contributor Author

emsesc commented Jul 11, 2021

I had a thought, to prevent students merging thier PRs at the wrong time could it be possible to make the student repos require the bot as an approver on the PRs and only allow merge once approved or maybe auto merge. The bot at the correct time can approve the PR preventing early merges?

https://octokit.github.io/octokit.rb/Octokit/Client/Reviews.html
https://octokit.github.io/rest.js/v18#repos-set-admin-branch-protection

@ganning127 ganning127 mentioned this issue Jul 15, 2021
Closed
@ganning127
Copy link
Contributor

protected main branch to solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent students from accidentally merging pull requests ganning127/counselor
2 participants
@ganning127 @emsesc