Skip to content
This repository has been archived by the owner on Sep 12, 2020. It is now read-only.

Adding SSH Agent forwarding basic support #1

Merged
merged 1 commit into from Nov 17, 2011

Conversation

bendavis78
Copy link
Contributor

I've ported over the pull request from paramiko that implements basic SSH agent forwarding support (see here).

It seems from previous discussions that no one really knows a good way to write official tests for this, but, I can say that it seems to work well for me in the few times that I've tried it with fabric.

@bitprophet
Copy link
Owner

Thanks for taking care of porting this.

Unfortunately, the original patch uses select.poll which is unavailble on stock OS X Python builds, and is thus unacceptable (I require that Fabric & its dependent libraries work on Apple's Python builds since a large portion of the userbase, myself included, use them.)

I'll try to take a stab myself at replacing it, a quick check implies that select.select and select.poll are roughly the same in capability (with poll being more efficient at large numbers of connections, which should not be a significant problem in most use cases) even if the API is quite different.

bitprophet added a commit that referenced this pull request Nov 17, 2011
@bitprophet
Copy link
Owner

Easier than I expected, thankfully. And...less verbose than what it replaces. Still works fine on Linux, not that I was worried it wouldn't.

While I'm here I think I will address some other uglies, like old-style classes (seriously? jeez)

bitprophet added a commit that referenced this pull request Nov 17, 2011
bitprophet added a commit that referenced this pull request Nov 17, 2011
@bitprophet bitprophet merged commit 35a1736 into bitprophet:master Nov 17, 2011
@bitprophet
Copy link
Owner

This now works OK for me on both OS X (Python 2.5) and Linux (Python 2.7). I'm going to close it out, though I may try to get some folks to beta test before it goes out for reals and will reopen if issues come up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants