Skip to content
This repository has been archived by the owner on Sep 12, 2020. It is now read-only.

show us the offending host key #32

Closed
wants to merge 1 commit into from

Conversation

thomasvs
Copy link

@thomasvs thomasvs commented Jul 2, 2012

No description provided.

@bitprophet
Copy link
Owner

Can you provide a quick way to reproduce the error case this is modifying so I can verify it on my end?

Context implies it's re: poorly formatted or corrupted line entries in a known_hosts file, but I'm not entirely sure how to create one that would trip this offhand. Could poke around but would prefer not to ;)

@thomasvs
Copy link
Author

thomasvs commented Jul 8, 2012

I don't know how it happened, but there was some extra characters in the middle of one of my host keys, something like [afdh] (including the brackets I think. I deleted the offending entry, sorry. I suggest you try with both even and odd number of characters as iirc it's supposed to be a base64 encoding ?

@bitprophet
Copy link
Owner

Yea, I just added one new character to an existing host key and got the binascii error. Cherry-picked your fix and got the new exception. Looks good to me 👍 Thanks!

@bitprophet bitprophet closed this Jul 15, 2012
bitprophet added a commit that referenced this pull request Jul 15, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants