New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Cordova (Android projects) #5

Closed
vgaidarji opened this Issue Jan 23, 2016 · 22 comments

Comments

Projects
None yet
2 participants
@vgaidarji

vgaidarji commented Jan 23, 2016

I'm eager to create a step for Cordova installation.

Appropriate request in uservoice: https://bitrise.uservoice.com/forums/235233-general/suggestions/9285630-install-cordova-and-ionic

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
@viktorbenei

viktorbenei Jan 23, 2016

Member

That's awesome! Let us know if you need any help / pointers.

I would suggest you to:

  1. First create a script and test it on bitrise.io, to install Cordova & verify that it's working as expected
  2. When it's working correctly you can send a pull request to make it pre-installed, if something takes a long time to install - https://github.com/bitrise-io/bitrise.io#request-a-tool-to-be-pre-installed
Member

viktorbenei commented Jan 23, 2016

That's awesome! Let us know if you need any help / pointers.

I would suggest you to:

  1. First create a script and test it on bitrise.io, to install Cordova & verify that it's working as expected
  2. When it's working correctly you can send a pull request to make it pre-installed, if something takes a long time to install - https://github.com/bitrise-io/bitrise.io#request-a-tool-to-be-pre-installed
@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Jan 23, 2016

Sure, thank you 👍

vgaidarji commented Jan 23, 2016

Sure, thank you 👍

@vgaidarji vgaidarji changed the title from Install Cordova to Install Cordova (Android projects) Feb 1, 2016

@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Feb 13, 2016

I've finished docker image with preinstalled cordova dependencies configuration and published it to dockerhub vgaidarji/docker-android-cordova.
Than, I've compiled sample cordova android project using new docker image at bitrise.io, and everything just worked fine.
Probably, not only Android projects can be build using this docker image, but other non-iOS platforms too. I didn't check it.
Cordova Android projects do not require gradlew path to be set, cordova automatically uses existing in Android project gradlew.

@viktorbenei Could you please check everything on your side, so we can move further with bitrise-io/bitrise-steplib#319

vgaidarji commented Feb 13, 2016

I've finished docker image with preinstalled cordova dependencies configuration and published it to dockerhub vgaidarji/docker-android-cordova.
Than, I've compiled sample cordova android project using new docker image at bitrise.io, and everything just worked fine.
Probably, not only Android projects can be build using this docker image, but other non-iOS platforms too. I didn't check it.
Cordova Android projects do not require gradlew path to be set, cordova automatically uses existing in Android project gradlew.

@viktorbenei Could you please check everything on your side, so we can move further with bitrise-io/bitrise-steplib#319

@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Feb 13, 2016

For our Docker based stack you can create an issue or pull request at:
bitrise-base, for generic tools and configurations (which are not related to Android)
android, for Android related tools and configurations

Should I create an issue at https://github.com/bitrise-docker/android or this PR is enough?

vgaidarji commented Feb 13, 2016

For our Docker based stack you can create an issue or pull request at:
bitrise-base, for generic tools and configurations (which are not related to Android)
android, for Android related tools and configurations

Should I create an issue at https://github.com/bitrise-docker/android or this PR is enough?

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
@viktorbenei

viktorbenei Feb 13, 2016

Member

Awesome! Thanks so much for your work & for the infos! We'll get back to you on Monday, and we'll let you know what our suggested method would be to move forward (whether it would be good to merge your changes into the Android docker image, or to keep it separate, etc.)

Member

viktorbenei commented Feb 13, 2016

Awesome! Thanks so much for your work & for the infos! We'll get back to you on Monday, and we'll let you know what our suggested method would be to move forward (whether it would be good to merge your changes into the Android docker image, or to keep it separate, etc.)

@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Feb 13, 2016

Attaching screenshot with images size, might be useful:

screen shot 2016-02-13 at 8 11 05 pm

vgaidarji commented Feb 13, 2016

Attaching screenshot with images size, might be useful:

screen shot 2016-02-13 at 8 11 05 pm

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
@viktorbenei

viktorbenei Feb 13, 2016

Member

That's quite good, maybe we'll add it to the Android image then. We'll discuss this on Monday, thanks again for the infos! And of course feel free to share your opinion, whether we should add this or keep separated.

Member

viktorbenei commented Feb 13, 2016

That's quite good, maybe we'll add it to the Android image then. We'll discuss this on Monday, thanks again for the infos! And of course feel free to share your opinion, whether we should add this or keep separated.

@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Feb 13, 2016

As for me, keeping it separate is a good option. This way images will have only required tools and won't be overloaded.

From other side, it's only ~150 mb extra. But I wouldn't consider the size here. It's better to keep things separated.

I believe, that in future bitrise.io will support tons of platforms and project types.

vgaidarji commented Feb 13, 2016

As for me, keeping it separate is a good option. This way images will have only required tools and won't be overloaded.

From other side, it's only ~150 mb extra. But I wouldn't consider the size here. It's better to keep things separated.

I believe, that in future bitrise.io will support tons of platforms and project types.

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
@viktorbenei

viktorbenei Feb 13, 2016

Member

That's a really good point, but in case we keep it separate we'll have to come up with a maintainable collection / solution for pre cached images.

Member

viktorbenei commented Feb 13, 2016

That's a really good point, but in case we keep it separate we'll have to come up with a maintainable collection / solution for pre cached images.

@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Feb 13, 2016

Anyway both solutions are fine with me :)

vgaidarji commented Feb 13, 2016

Anyway both solutions are fine with me :)

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
@viktorbenei

viktorbenei Feb 13, 2016

Member

Thanks, we'll discuss it and will try to pick the best solution 😊

Member

viktorbenei commented Feb 13, 2016

Thanks, we'll discuss it and will try to pick the best solution 😊

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
@viktorbenei

viktorbenei Feb 19, 2016

Member

I believe the only thing left is the official decision about the Docker Image (whether it should be kept separate, should be moved to a bitrise GH organization, merged into the Android image, etc.) - right? @donvigo

Member

viktorbenei commented Feb 19, 2016

I believe the only thing left is the official decision about the Docker Image (whether it should be kept separate, should be moved to a bitrise GH organization, merged into the Android image, etc.) - right? @donvigo

@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Feb 19, 2016

yes, exactly :)

vgaidarji commented Feb 19, 2016

yes, exactly :)

@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Feb 19, 2016

Once we finish with this, probably (depends of free time after work :)), I'll take care of other cordova integrations.

vgaidarji commented Feb 19, 2016

Once we finish with this, probably (depends of free time after work :)), I'll take care of other cordova integrations.

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
@viktorbenei

viktorbenei Feb 19, 2016

Member

Do you have a short setup guide? The related Step is now available in the official step lib, so a short setup guide would help others to use cordova right now, with your docker image - until we have an official decision about the Docker Image situation

Member

viktorbenei commented Feb 19, 2016

Do you have a short setup guide? The related Step is now available in the official step lib, so a short setup guide would help others to use cordova right now, with your docker image - until we have an official decision about the Docker Image situation

@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Feb 19, 2016

well, the setup guide will have only few instructions, like "specify custom image in settings" and that's pretty much it. I don't have the guide right now, but I can write it somewhere. What's the best place for it?

vgaidarji commented Feb 19, 2016

well, the setup guide will have only few instructions, like "specify custom image in settings" and that's pretty much it. I don't have the guide right now, but I can write it somewhere. What's the best place for it?

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
@viktorbenei

viktorbenei Feb 19, 2016

Member

If you want to you can just write it here, or if you have a blog you can write about it there and we'll link from the DevCenter, or we'll just add it to the DevCenter directly.

Member

viktorbenei commented Feb 19, 2016

If you want to you can just write it here, or if you have a blog you can write about it there and we'll link from the DevCenter, or we'll just add it to the DevCenter directly.

@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Feb 19, 2016

Ok, got it. Looks like the time to start writing personal blog 👍
I'll try to fill this gap asap, and update the status here. Thank you.

vgaidarji commented Feb 19, 2016

Ok, got it. Looks like the time to start writing personal blog 👍
I'll try to fill this gap asap, and update the status here. Thank you.

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
@viktorbenei

viktorbenei Feb 19, 2016

Member

Awesome, thank you! If you need any help, we're always here / on Slack ;)

Member

viktorbenei commented Feb 19, 2016

Awesome, thank you! If you need any help, we're always here / on Slack ;)

@vgaidarji

This comment has been minimized.

Show comment
Hide comment
@vgaidarji

vgaidarji Feb 28, 2016

@viktorbenei Please check "How to build Cordova-based Android project on bitrise.io", and if it fits (I hope it does), than feel free to add to bitrise blog ;)

vgaidarji commented Feb 28, 2016

@viktorbenei Please check "How to build Cordova-based Android project on bitrise.io", and if it fits (I hope it does), than feel free to add to bitrise blog ;)

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
Member

viktorbenei commented Feb 29, 2016

@viktorbenei

This comment has been minimized.

Show comment
Hide comment
Member

viktorbenei commented Jan 5, 2017

@viktorbenei viktorbenei closed this Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment