Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOL-2041] Access Environment item values with GetKeyValuePair instead of [] operator #719

Merged
merged 3 commits into from Apr 28, 2020

Conversation

Szabadember
Copy link
Contributor

Code should check if it is possible to cast to string and return the default representation of the value for non nil values.

@Szabadember Szabadember requested a review from a team April 23, 2020 15:29
@Szabadember Szabadember self-assigned this Apr 23, 2020
@Szabadember Szabadember requested review from lpusok and removed request for a team April 23, 2020 15:29
@Szabadember Szabadember changed the title [TOOL-2041] Check cast [TOOL-2041] Access Environment item values with GetKeyValuePair instead of [] operator Apr 23, 2020
@Szabadember
Copy link
Contributor Author

The problem was that the code used the [] operator instead of GetKeyValuePair the casting logic is already implemented there.

@godrei godrei merged commit e7bdce2 into master Apr 28, 2020
@trapacska trapacska deleted the TOOL-2041-fix branch April 28, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants