fixed xamarin build command #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdobmayer
reviewed
Jan 5, 2018
cmd/xamarin.go
Outdated
| continue | ||
|
|
||
| if enableVerboseLog { | ||
| xamSlnJSON, err := json.MarshalIndent(xamSln, "", "\t") |
kdobmayer
reviewed
Jan 5, 2018
cmd/xamarin.go
Outdated
| if enableVerboseLog { | ||
| xamSlnJSON, err := json.MarshalIndent(xamSln, "", "\t") | ||
| if err == nil { | ||
| log.Debugf("xamSln:\n%s", xamSlnJSON) |
There was a problem hiding this comment.
Shouldn't abbreviate in debug log (xamSln)
kdobmayer
reviewed
Jan 5, 2018
cmd/xamarin.go
Outdated
| continue | ||
| } | ||
|
|
||
| archivableProjectConfigNames := []string{} |
There was a problem hiding this comment.
kdobmayer
reviewed
Jan 5, 2018
cmd/xamarin.go
Outdated
| ) | ||
| archivableSolutionConfigNameMap := map[string]bool{} | ||
| for _, project := range xamSln.ProjectMap { | ||
| if project.SDK != constants.SDKIOS { |
There was a problem hiding this comment.
if project.SDK != constants.SDKIOS || project.OutputType != "exe" {
continue
}
kdobmayer
reviewed
Jan 5, 2018
cmd/xamarin.go
Outdated
| } | ||
|
|
||
| archivableProjectConfigNames := []string{} | ||
| for configName, config := range project.Configs { |
There was a problem hiding this comment.
name, config, or name, c
https://github.com/golang/go/wiki/CodeReviewComments#variable-names
kdobmayer
reviewed
Jan 5, 2018
cmd/xamarin.go
Outdated
| return printXamarinScanFinishedWithError( | ||
| "No acceptable Project found in the provided Solution, or none can be used for iOS Archive.", | ||
| ) | ||
| archivableSolutionConfigNameMap := map[string]bool{} |
There was a problem hiding this comment.
variable name should imply that it is a set
kdobmayer
reviewed
Jan 5, 2018
cmd/xamarin.go
Outdated
| return printXamarinScanFinishedWithError( | ||
| "No acceptable Project found in the provided Solution, or none can be used for iOS Archive.", | ||
| ) | ||
| archivableSolutionConfigNameMap := map[string]bool{} |
There was a problem hiding this comment.
from line 82 to 113 could be a separate function:
func archivableSolutionConfigNames(map[string]project.Model) []stringand call with
archivableSolutionConfigNames(xamSln.ProjectMap)
kdobmayer
reviewed
Jan 5, 2018
xamarin/xamarin.go
Outdated
| projectName := strings.Replace(xamarinCmd.ProjectName, ".", "_", -1) | ||
|
|
||
| archivesBeforeBuild, err := listArchives() | ||
| builder, err := builder.New(xamarinCmd.SolutionFilePath, []constants.SDK{constants.SDKIOS}, buildtools.Msbuild) |
There was a problem hiding this comment.
builder variable shadowing builder package
kdobmayer
reviewed
Jan 5, 2018
xamarin/xamarin.go
Outdated
| cmd, err := command.NewFromSlice(cmdArgs) | ||
| if err != nil { | ||
| return "", "", fmt.Errorf("Failed to create Xamarin command, error: %s", err) | ||
| callback := func(solutionName string, projectName string, sdk constants.SDK, testFramwork constants.TestFramework, commandStr string, alreadyPerformed bool) { |
There was a problem hiding this comment.
Could be defined outside of this function, and use an underscore _ for not used variables.
kdobmayer
reviewed
Jan 5, 2018
xamarin/xamarin.go
Outdated
| for _, archiveBeforeBuild := range archivesBeforeBuild { | ||
| if archiveAfterBuild == archiveBeforeBuild { | ||
| isNew = false | ||
| archivesDuringBuild := []string{} |
There was a problem hiding this comment.
kdobmayer
reviewed
Jan 5, 2018
cmd/xamarin.go
Outdated
| } | ||
| } | ||
| if len(archivableSolutionConfigNames) < 1 { | ||
| return printXamarinScanFinishedWithError(`No acceptable Configuration found in the provided Solution and Project, or none can be used for iOS "Archive for Publishing".`) |
There was a problem hiding this comment.
Implement builtin error interface instead of calling a function which is printing and returning an error.
type ArchiveError struct {
toolName string
msg string
}
func (e ArchiveError) Error() string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.