Error log updated for: #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"If the xcode archive is success, we have the archive required codesigning files. Then codesigndoc asks for the distribution method, if method selected, which codesigning files are not exist on the developer's machine it mentions the fail, and asks if do you want to export other files? If no selected it finishes with strange error: no ipa export code sign groups collected"
godrei
reviewed
May 29, 2018
codesigndoc/codesigndoc.go
Outdated
| errorString := "\n🚨 " + colorstring.Red("Failed to collect codesigning files for the selected distribution type.\n") + | ||
| colorstring.Yellow("Export an ipa with the same export method which code signing files you want to collect (e.g app-store if you want to collect the code signing files for app-store distribution) in your local xcode and run codesigndoc again.\n") + | ||
| colorstring.Yellow("If the tool fails please report the issue with the codesigndoc log and the local ipa exportOptions.plist") | ||
| return false, false, fmt.Errorf(colorstring.Yellow(errorString)) |
Contributor
There was a problem hiding this comment.
why do you use colorstring.Yellow for an already colored log?
godrei
reviewed
May 29, 2018
codesigndoc/codesigngroup.go
Outdated
| if len(filteredCodeSignGroups) == 0 { | ||
| fmt.Println() | ||
| log.Errorf(collectCodesigningFilesInfo) | ||
| log.Errorf("🚨 Could not find any valid code signing file for the selected export method:") |
Contributor
There was a problem hiding this comment.
Could not find the codesigning files for {app-store|ad-hoc|development|enterprise} ipa export:
godrei
requested changes
May 29, 2018
Contributor
godrei
left a comment
godrei
left a comment
There was a problem hiding this comment.
pls have a look at my comments
Squashed commits: [b19a1ac] PR clean - fix
BirmacherAkos
force-pushed
the
error_log_update
branch
from
cad157b to
b63a6fe
Compare
trapacska
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"If the xcode archive is success, we have the archive required codesigning files. Then codesigndoc asks for the distribution method, if method selected, which codesigning files are not exist on the developer's machine it mentions the fail, and asks if do you want to export other files? If no selected it finishes with strange error: no ipa export code sign groups collected"