Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

#28 Return module nested in another directory #29

Merged

Conversation

@szymanp1
Copy link
Contributor

szymanp1 commented May 30, 2019

Steps now should recognize and list modules that are nested inside another directory.

I tested this with bitrise-step-android-lint running locally with replaced go-android package and seems to be working fine. Can I run any additional tests?

This is the very first thing I wrote in Go 馃帀

fixes #28

@szymanp1

This comment has been minimized.

Copy link
Contributor Author

szymanp1 commented Jun 3, 2019

@trapacska any chance to have that reviewed? I can't use any of Android-specific build steps (Lint, Tests) without that in my project.

@trapacska

This comment has been minimized.

Copy link
Contributor

trapacska commented Jul 24, 2019

Hi @szymanp1 !

I approved the PR as it LGTM. Checkint the CI and running it. If ok then I'll merge.

@trapacska trapacska merged commit 34d6f20 into bitrise-io:master Jul 24, 2019
3 checks passed
3 checks passed
ci/bitrise/451090fbfcb02cf4/pr Passed - go-android [CI - Linux LTS]
Details
ci/bitrise/bd92c03d09fc4017/pr Passed - go-android [CI - Linux]
Details
ci/bitrise/f7f72ef6ae43d554/pr Passed - go-android [CI - Xamarin Latest]
Details
@trapacska

This comment has been minimized.

Copy link
Contributor

trapacska commented Jul 24, 2019

Thank you for the PR! 馃殌

@szymanp1

This comment has been minimized.

Copy link
Contributor Author

szymanp1 commented Jul 24, 2019

Will this fix be automatically available in all steps that use this as a dependency? Or do they need to be updated and released?

Edit: I looked into that and think that every individual step has to update its dependencies in .lock file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can鈥檛 perform that action at this time.