From 7fa57b355de3e19fd4f589357d144f1a7a4a3051 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kriszti=C3=A1n=20G=C3=B6drei?= Date: Fri, 7 Oct 2022 09:44:10 +0200 Subject: [PATCH 1/2] Remove CompareVersions logs --- versions/versions.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/versions/versions.go b/versions/versions.go index 4481154..de1662d 100644 --- a/versions/versions.go +++ b/versions/versions.go @@ -1,7 +1,7 @@ package versions import ( - "log" + "fmt" "strconv" "strings" ) @@ -36,14 +36,12 @@ func CompareVersions(version1, version2 string) (int, error) { for i, num := range version1Slice { num1, err := strconv.ParseInt(num, 0, 64) if err != nil { - log.Println("Failed to parse int:", err) - return -2, err + return -2, fmt.Errorf("failed to parse int (%s): %s", num, err) } num2, err2 := strconv.ParseInt(version2Slice[i], 0, 64) if err2 != nil { - log.Println("Failed to parse int:", err2) - return -2, err + return -2, fmt.Errorf("failed to parse int (%s): %s", num, err) } if num2 > num1 { From 389787b380c3051e1ee6b31da7a03e7ee9250799 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kriszti=C3=A1n=20G=C3=B6drei?= Date: Fri, 7 Oct 2022 11:30:35 +0200 Subject: [PATCH 2/2] Update versions/versions.go Co-authored-by: lpusok <7979773+lpusok@users.noreply.github.com> --- versions/versions.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/versions/versions.go b/versions/versions.go index de1662d..30c20ad 100644 --- a/versions/versions.go +++ b/versions/versions.go @@ -41,7 +41,7 @@ func CompareVersions(version1, version2 string) (int, error) { num2, err2 := strconv.ParseInt(version2Slice[i], 0, 64) if err2 != nil { - return -2, fmt.Errorf("failed to parse int (%s): %s", num, err) + return -2, fmt.Errorf("failed to parse int (%s): %s", version2Slice[i], err2) } if num2 > num1 {