Add option for Linkifying user name and channel name #22
Conversation
There was a problem hiding this comment.
Awesome, thanks for the contribution @tomoima525 ! :)
I left a few comments for discussion, but I'm happy with the PR as it is, the code is 👍
step.yml
Outdated
| @@ -151,6 +151,16 @@ inputs: | |||
| leave this option empty then the default one will be used. | |||
| is_expand: true | |||
| is_required: false | |||
| - link_names: "no" | |||
There was a problem hiding this comment.
Shouldn't we enable this by default? Seems useful enough to be default yes IMO
There was a problem hiding this comment.
Yeah, that is true! addressed bdff5e3
step.yml
Outdated
| opts: | ||
| title: "Link Names" | ||
| description: | | ||
| Link names such as @username |
There was a problem hiding this comment.
I'd also add a channel example here. E.g.
Linkify names in the message such as `@slackbot` or `#random`
What do you think?
There was a problem hiding this comment.
Agree, should include channel name too -> 779e002
|
@viktorbenei thanks for the comments, I made fix to them |
main.go
Outdated
| @@ -31,6 +31,7 @@ type ConfigsModel struct { | |||
| EmojiOnError string | |||
| IconURL string | |||
| IconURLOnError string | |||
| IsLinkNamesOn bool | |||
There was a problem hiding this comment.
one last minor thing, please rename this property to just IsLinkNames, to conform to the naming of the other properties
|
Thank you @tomoima525 ! :) Found one last thing, sorry I missed this the first time. |
|
@viktorbenei Sure thing! Just addressed |
There was a problem hiding this comment.
Perfect, thank you very much @tomoima525 ! :)
I'll release a new version ASAP!
|
Released in v2.6.1 - should be available in the steplib soon |
Hi! Thanks for the great service! I added a small feature to slack message step.
Done in this PR
this is related issue #13