Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing packages for cert and profile download/installaltion #78

Merged
merged 14 commits into from Jan 6, 2023

Conversation

lpusok
Copy link
Contributor

@lpusok lpusok commented Jan 5, 2023

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

Replaced download and installation of certificates and profiles with already existing library code.
This solves an issue where the HTTP error codes of network queries were not checked.

Changes

Log before:

https://app.bitrise.io/build/95c6754a-6d9e-469a-807f-72aacba19690
Bitrise_-Mobile_Continuous_Integration_and_Delivery-_iOS___Android_Build_Automation

Log after:

https://app.bitrise.io/build/394e7782-d403-409e-a5ad-015e7af6b3be
Bitrise_-Mobile_Continuous_Integration_and_Delivery-_iOS___Android_Build_Automation

Investigation details

Decisions

@lpusok lpusok changed the title Use existing packages for cert and profile download and installaltion Use existing packages for cert and profile download/installaltion Jan 5, 2023
@@ -3,10 +3,11 @@ module github.com/bitrise-steplib/steps-certificate-and-profile-installer
go 1.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Bumping this to Go 1.17 and running go mod tidy will list the implicit dependencies as well in a separate require block

Copy link
Contributor

@ofalvai ofalvai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome code cleanup!

@lpusok lpusok merged commit b113c98 into master Jan 6, 2023
@lpusok lpusok deleted the SWAT-1317 branch January 6, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants