New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use existing packages for cert and profile download/installaltion #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpusok
changed the title
Use existing packages for cert and profile download and installaltion
Use existing packages for cert and profile download/installaltion
Jan 5, 2023
ofalvai
reviewed
Jan 6, 2023
@@ -3,10 +3,11 @@ module github.com/bitrise-steplib/steps-certificate-and-profile-installer | |||
go 1.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Bumping this to Go 1.17 and running go mod tidy
will list the implicit dependencies as well in a separate require
block
ofalvai
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.yml
andREADME.md
is updated with the changes (if needed)Version
Requires a PATCH version update
Context
Replaced download and installation of certificates and profiles with already existing library code.
This solves an issue where the HTTP error codes of network queries were not checked.
Changes
Log before:
https://app.bitrise.io/build/95c6754a-6d9e-469a-807f-72aacba19690
Log after:
https://app.bitrise.io/build/394e7782-d403-409e-a5ad-015e7af6b3be
Investigation details
Decisions