dep update: normalize the scheme's name before comparing it with the input #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`prune` section with `unused-packages = true`
godrei
approved these changes
Feb 14, 2019
trapacska
approved these changes
Feb 14, 2019
Contributor
trapacska
left a comment
trapacska
left a comment
There was a problem hiding this comment.
For me the title of this PR was a little bit misleading. I thought I need to check something else beside of the dep update. I think we shall not unclude dep update changelogs as this way it was listed for only for one package, however you updated 30+ dependency as well, and there is no changelog for those.
lszucs
approved these changes
Feb 14, 2019
lpusok
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and re-run dep init to clean the unused dependencies and to add the
prunesection withunused-packages = true