Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug logging for testsummaries #121

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@kylefleming
Copy link
Contributor

kylefleming commented Jul 25, 2019

The xcode-test step is logging a large amount of data during normal execution, which seems undesirable. I reduced the log level of some of this output to debug level. This way the output will be hidden normally but can still be viewed when needed by turning on verbose mode.

The "lastSubtests" and "No subactivities found for activity" logs are producing most of the output for my builds and seem to be purely informational.

If "No subactivities found for activity" is truely a warning that needs to be heeded by the user, then the message might be better as an info or warn level. Otherwise, if it's not something that the user needs to worry about, and was put there for debugging while coding the step, then I think debug level is most appropriate.

Along a similar vein, if the "no activity summaries found for test" is notifying the user of something that shouldn't normally happen, then an info or warn level might be more appropriate.

I've set all 3 to debug level in this PR, but can change it depending on feedback of the maintainers.

@lpusok
lpusok approved these changes Oct 2, 2019
@godrei godrei merged commit 57ecb07 into bitrise-steplib:master Oct 3, 2019
1 check passed
1 check passed
ci/bitrise/00e1569ea520335d/pr Passed - steps-xcode-test [CI]
Details
@lpusok

This comment has been minimized.

Copy link
Contributor

lpusok commented Oct 3, 2019

Thanks @kylefleming.

@kylefleming kylefleming deleted the kylefleming:debug-logging branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.