Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track total amount in collateral #1089

Closed
abitmore opened this issue Jun 24, 2018 · 2 comments

Comments

@abitmore
Copy link
Member

commented Jun 24, 2018

User Story
Quoting bitshares/bitshares-ui#890 (comment):

I'm looking for a tracker to be added to the reference wallet explorer that keeps track of the actual circulating supply of BTS that aren't locked up as collateral for MPAs.

Right now, the explorer only shows the "Current Supply" but doesn't not take into account the amount of BTS that's locked up in smart contracts. I think this information is extremely important because as the amount of MPAs increase, the amount of circulating BTS should decrease which means that BTS becomes more scarce and should apply some upward pressure on the value of BTS.

I know the market value of each MPA is tracked individually, but it takes a long time to add up the total market caps for all MPAs and then do the math to guesstimate the amount of BTS locked up as collateral.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context (optional)
I think we need a new API or a new data field in asset dynamic data object to implement this feature. Can name the new data field "total_amount_in_collateral" or so.

Note: tracking this new data will negatively impact node performance, so best make it optional.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Aug 17, 2018

@ryanRfox ryanRfox moved this from New -Awaiting Core Team Evaluation to Unassigned - Features & Enhancements in Project Backlog Feb 27, 2019

@abitmore abitmore referenced this issue May 28, 2019
2 of 17 tasks complete

@pmconrad pmconrad added this to To do in Feature Release (3.3.0) via automation Jun 25, 2019

@pmconrad pmconrad removed this from Unassigned - Features & Enhancements in Project Backlog Jun 25, 2019

@pmconrad pmconrad self-assigned this Jun 27, 2019

@pmconrad pmconrad moved this from To do to In development in Feature Release (3.3.0) Jun 27, 2019

@ryanRfox ryanRfox moved this from In development to In testing in Feature Release (3.3.0) Jul 16, 2019

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Merged #1836 - please keep this open until release notes are created. Public API nodes should activate the new plugin when upgrading.

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Upgrade instructions are now mentioned in the release notes.

@pmconrad pmconrad closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.