New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI wallet: avoid directly overwriting wallet file on exit #1109

Closed
abitmore opened this Issue Jul 2, 2018 · 10 comments

Comments

Projects
3 participants
@abitmore
Member

abitmore commented Jul 2, 2018

One of my wallet files got corrupted today due to disk full. Fortunately I have backed up the keys.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
    • Assigned: @cogutvalera
    • Estimated: 3 hours (Remitted weeks 34-35)
  • Perform QA/Testing
  • Update Documentation
@abitmore

This comment has been minimized.

Member

abitmore commented Jul 2, 2018

#1050 is related.

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Jul 27, 2018

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Jul 27, 2018

as an idea: to save wallet file with another filename something like temp wallet file or backup

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Jul 27, 2018

only on exit or in save_wallet_file ?

@abitmore

This comment has been minimized.

Member

abitmore commented Jul 27, 2018

save_wallet_file.

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Jul 28, 2018

@abitmore abitmore removed this from New -Awaiting Core Team Evaluation in Project Backlog Jul 29, 2018

@abitmore abitmore added this to To do in Feature release (201810) via automation Jul 29, 2018

@abitmore abitmore moved this from To do to In progress in Feature release (201810) Jul 29, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Jul 30, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Jul 30, 2018

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Jul 30, 2018

my approximation/estimation is about 3 hours for this issue

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Jul 30, 2018

Thanks !

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Jul 31, 2018

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Jul 31, 2018

rebased already

@ryanRfox

This comment has been minimized.

Member

ryanRfox commented Jul 31, 2018

Assigned to @cogutvalera and added estimate for 3 hours.

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Jul 31, 2018

Thanks !

@abitmore abitmore removed this from In Development in Feature Release (201808) Aug 2, 2018

@abitmore abitmore added this to To do in Feature release (201810) via automation Aug 2, 2018

@abitmore abitmore moved this from To do to In progress in Feature release (201810) Aug 2, 2018

abitmore added a commit that referenced this issue Aug 17, 2018

Merge pull request #1195 from cogutvalera/valera_issue_1109
CLI wallet: avoid directly overwriting wallet file on exit #1109
@abitmore

This comment has been minimized.

Member

abitmore commented Aug 17, 2018

Fixed by #1195.

@abitmore abitmore closed this Aug 17, 2018

Feature release (201810) automation moved this from In progress to Done Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment