Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Private Testnet --create-genesis-json creates witness_node_data_dir #1118

Closed
cedar-book opened this issue Jul 4, 2018 · 6 comments

Comments

Projects
4 participants
@cedar-book
Copy link

commented Jul 4, 2018

Setup Private Testnet --create-genesis-json creates witness_node_data_dir

  • Windows 10 (64-bit)
  • WSL environment

Testing setup [Private Testnet steps] (https://dev.bitshares.works/en/master/development/testnets/private_testnet.html)

(step 3) When I run ./witness_node --create-genesis-json=my-genesis.json, creating a "my-genesis.json" and also "witness_node_data_dir" folder.

private-testnet-setup-1

It seems... go to main.cpp and check the "witness_node_data_dir" and "create_new_config_file()".
How can I stop this? Because (step 6) Creates a "data" Directory and also config.ini in it.

private-testnet-setup-2

private-testnet-setup-3

Impacts

  • [x ] Setup Private Testnet Data directory structure

** Installation **
Followed: https://dev.bitshares.works/en/master/development/installation/build_ubuntu.html

  • BitShares Core Release 2.0.180612

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@cedar-book

This comment has been minimized.

Copy link
Author

commented Jul 9, 2018

I checked a witness_node executable main() for a part of another issue and created a code flow (in page 8) to view the flow.

You may or may not have own data directory that does not matter. If --data-dir is not set in a command line when witness_node starts (and not find a config.ini), a witness_node_data_dir will be created (if not exists). So, if you create own data directory and forget to set the --data-dir when you start a witness_node, you get new default data directory and config.ini to start the witness_node.

@abitmore, I can think about two options. (1) update the logic or (2) in the documentation clearly mention (warn) to users; you have to define a data directory if you have own data directory (with config.ini), otherwise, witness_node_data_dir will be created and used a default config.ini.
Because of the config.ini, thought that might be better not to create an extra data directory. But we can do only the option (2). or something else?

@abitmore

This comment has been minimized.

Copy link
Member

commented Jul 9, 2018

You may or may not have own data directory that does not matter. If --data-dir is not set in a command line when witness_node starts (and not find a config.ini), a witness_node_data_dir will be created (if not exists). So, if you create own data directory and forget to set the --data-dir when you start a witness_node, you get new default data directory and config.ini to start the witness_node.

Correct.

(2) in the documentation clearly mention (warn) to users

Agreed.

@cedar-book

This comment has been minimized.

Copy link
Author

commented Jul 10, 2018

Added Note and Warning in a Private Testnet page. @abitmore, please review. This is the information how it was updated.
(updated links: 2019-2-1)

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Aug 17, 2018

@ryanRfox

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

I believe this may already be resolved, but going to add it to the next Feature Release so we test it out and validate our documentation. Here is the current Private Testnet Setup page.

@abitmore

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

I don't think we've worked on this issue.

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2019

Resolved by #1529

@pmconrad pmconrad closed this Feb 4, 2019

@abitmore abitmore removed this from New -Awaiting Core Team Evaluation in Project Backlog Feb 4, 2019

@abitmore abitmore added this to To do in Feature Release (201902) via automation Feb 4, 2019

@abitmore abitmore moved this from To do to Done in Feature Release (201902) Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.