New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cli_test #1192

Closed
abitmore opened this Issue Jul 27, 2018 · 4 comments

Comments

@abitmore
Member

abitmore commented Jul 27, 2018

@oxarbitrage wrote in #1177 (review):

one thing we should maybe consider(in a separated issue) is to add a function in cli_wallet tests to make a few of the common things that we need to do pretty much in all the tests.
connect to the server
set wallet password
import Nathan account
upgrade nathan
verify that the upgrade was successful
create a new account
save the private key for this new account in the wallet file
...
this can be in a test case that can be invoked, a function or even maybe a "database_fixture" version file for the cli.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
    • Assigned: @cogutvalera
    • Estimated: 10 hours (Remittance Weeks 34-35)
  • Perform QA/Testing
  • Update Documentation

@abitmore abitmore added the testing label Jul 27, 2018

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Jul 27, 2018

@abitmore

This comment has been minimized.

Member

abitmore commented Jul 27, 2018

I think this issue is a good place for adding clean shutdown tests.

Update: perhaps not a good place? There are quite some logic in the main function in programs/cli_wallet/main.cpp, perhaps hard to test.

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Aug 2, 2018

I want to claim this issue

@ryanRfox ryanRfox removed this from New -Awaiting Core Team Evaluation in Project Backlog Aug 3, 2018

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Aug 3, 2018

Thanks !

@ryanRfox ryanRfox added this to In Development in Community Claims Aug 3, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Aug 9, 2018

@ryanRfox ryanRfox moved this from In Development to In Testing in Community Claims Aug 9, 2018

abitmore added a commit that referenced this issue Aug 29, 2018

@oxarbitrage

This comment has been minimized.

Member

oxarbitrage commented Sep 28, 2018

this was closed by #1243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment