Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture Ctrl+C in cli_wallet when not in daemon mode #1193

Closed
abitmore opened this issue Jul 27, 2018 · 10 comments

Comments

Projects
4 participants
@abitmore
Copy link
Member

commented Jul 27, 2018

When a cli_wallet process is not running in daemon mode (not stared with--daemon), if Ctrl+C is pressed, it will exit uncleanly, which is dangerous because it may cause loss of unsaved private keys.

IMHO we should save wallet file before shutting down.

By the way, Ctrl+C was the only option for Windows users to exit from cli_wallet. Now we've added a quit command in #1104, so Windows users can exit normally now. Linux and MacOS users can already exit from cli_wallet by pressing Ctrl+D, now they can use the quit command as well.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
    • Assigned: @cogutvalera
    • Estimated: 7 hours
      • Original implementation, merged, reverted: 3 hours (paid Core Team - Weeks 30-31)
      • Bugfix/refactoring: 4 hours (paid Core Team - Weeks 30-31)
  • Perform QA/Testing
  • Update Documentation

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Jul 27, 2018

@abitmore abitmore added the cli label Jul 27, 2018

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

I want to claim this issue, my estimation/approximation for this issue is about 3 hours

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

Thanks for assigning this issue to me !

abitmore added a commit that referenced this issue Jul 30, 2018

Merge pull request #1207 from cogutvalera/valera_issue_1193
Capture Ctrl+C in cli_wallet when not in daemon mode #1193
@abitmore

This comment has been minimized.

Copy link
Member Author

commented Jul 30, 2018

Fixed by #1207.

@abitmore abitmore closed this Jul 30, 2018

Feature Release (201808) automation moved this from To Do to Done Jul 30, 2018

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Jul 30, 2018

I want to claim this issue, my estimation/approximation for this issue is about 3 hours

Looks good to me. Thanks. Pinging @ryanRfox.

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

Thank you very much !

@ryanRfox

This comment has been minimized.

Copy link
Member

commented Jul 31, 2018

Assigned @cogutvalera and estimated 3 hours.

@ryanRfox ryanRfox added this to Ready for Integration in Community Claims Jul 31, 2018

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Jul 31, 2018

Thanks !

@cogutvalera cogutvalera referenced this issue Aug 1, 2018

Closed

cli_wallet doesn't exit on quit nor EOF #1216

3 of 8 tasks complete

abitmore added a commit that referenced this issue Aug 2, 2018

abitmore added a commit that referenced this issue Aug 2, 2018

Merge pull request #1220 from bitshares/revert-1207-valera_issue_1193
Revert "Capture Ctrl+C in cli_wallet when not in daemon mode #1193"

@pmconrad pmconrad added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Aug 2, 2018

@pmconrad pmconrad removed this from To Do in Feature Release (201808) Aug 2, 2018

@pmconrad pmconrad removed this from New -Awaiting Core Team Evaluation in Project Backlog Aug 2, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Aug 3, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Aug 3, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Aug 10, 2018

@abitmore abitmore added this to To do in Feature Release (201902) via automation Sep 14, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Sep 28, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Sep 28, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Sep 28, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 19, 2018

pmconrad added a commit that referenced this issue Oct 20, 2018

Merge pull request #1232 from cogutvalera/issue_1193
Capture Ctrl+C in cli_wallet when not in daemon mode #1193
@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Oct 20, 2018

Resolved with #1232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.