Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Distribute Asset Market Fees to Referral Program #1268
Example use cases
Additional Context (optional)
CORE TEAM TASK LIST
We have PoC ready for this functionality. Most likely this should be converted to a BSIP, technical specification is ready as well, see below.
reward_percent asset option
Percent of market fee that will be paid to buyer's registrar. Set by UIA issuer.
market_sharing_whitelist asset option
TODO An optional whitelist (configurable by the UIA Issuer) could provide increased control over who is eligible to get market rewards.
New database and wallet api methods
get_account_reward(account, asset_symbol) - Returns information about the reward amount for specific asset.
A new BitShares object type in implementation space impl_account_reward_object_type = 2.18.X that tracks the rewards of a single account/asset pair
A new index that stores objects of account_reward_object-type in graphene::database and allow random fast access to objects by given criteria
A new operation used to transfer reward to the account's balance.
graphene::chain::database new methods
Add: reward_tests.cpp (asset_rewards_test, asset_claim_reward_test)
Modified: fee_tests.cpp, uia_tests.cpp
added this to New -Awaiting Core Team Evaluation
in Project Backlog
Aug 21, 2018
Not bad. Please go ahead with a BSIP (replaces BSIP4).
Best if you have developers to help implement it.
Great initiative @charyury
Let's discuss an estimate for drafting the BSIP. I've assigned you to this Issue. We will use this to track progress of the BSIP. However, the BSIP itself will be drafted in the /BSIPS repo, not the /bitshare-core repo.
I refined the Core Team Task List within the description. We can adjust as needed going forward.
Hello, here are the answers from OpenLedger's team to abit's concerns:
We propose to use market_fee_reward_percent (defined in the asset options) for the registrar and then use the original Bitshares mechanism and original reward percentage field (defined for each account during registration) to split between the registrar and referrer.
Market fee reward is accumulated on the user account. The users decide when they want to claim the market fee reward and move it to their active balance. There is another operation created asset_claim_reward_operation. Each user pays network fee to call this operation.
We don't recommend to make additional operation reward_split, because it leads to a significant blockchain load increase. So, we offer to add extra attributes to fill_order_operation.
We have updated our description.
That's a very good point! We have thought about it but did not add it to the description as it was not implemented in the prototype yet.
the official BSIP-43 is here:
This is not affecting BTS or any other asset in any way as the fees are being distributed to referral program (registrars and referrals), not to specific asset holders.
Great direction but in my opinion there are some small lacks for mass adoption.
@thul3 Thanks a lot for your valuable comments. Most of them are valid and can be encouraged as a good supplement to BSIP-43.
In any case, the BSIP 43 was a start point of the market fees sharing. Your suggestions can be posted as separate BSIP or supplement to BSIP-43 and then discussed with the community.