Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[ES plugin] Wrong value of additional_data.fill_data.fill_order #1295
USD -> BTS:
BTS -> USD:
The fill_price is same in both ways of the deals, wheras pay/recieve assets are inverted.
Elastic Search database content.
Steps To Reproduce
CORE TEAM TASK LIST
Ah..another one for the base/quote design :P
If you look at the original op, you'll see that it too keeps price at a preferred base/quote order:
So the plugin is simply copying the core representation...
Dont ask me why though
referenced this issue
Sep 30, 2018
I was thinking on pros and cons about adding this feature and decided to add it by the following:
In regards to current applications, ES plugin is currently being used by more third parties than i was expecting including openledger, payger, cyptobridge and others so need to be careful when making changes.
In regards to deprecation i have an elasticsearch plugin version from Dascoin that allows to index all the fields from all the operations. I am porting and testing this now, this will eventually deprecate the additional data we have now but at first plugin will support both options to remain compatible.
Yes, sorry @Zapata , i closed it too fast. We can reopen if you think is needed.
The code in the pull request will add some additional stuff to the additional data :)
For fee data we have the fee amount calculated with precision and the asset name on what the fee was paid:
For transfer data we added the transfer amount in units and the asset name:
For fill orders we added pays_asset_name, pays_amount_units, receives_asset_name, receives_amount_units and fill_price_units: