New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to perform testing #1298

Closed
sachushaji opened this Issue Aug 30, 2018 · 13 comments

Comments

Projects
5 participants
@sachushaji

sachushaji commented Aug 30, 2018

Bug Description
I was trying to test the performance testing for the implementation , but i am not able to test its performance. I followed the steps specified in the documentation but didn't gave any results.

Impacts
Not able to confirm whether the implementation achieves the specified transaction rates.

Steps To Reproduce
1.Successfully built dependencies and was able to launch the witness node.
2.Followed the steps specified in the testing document and was not able to launch the witness node.
3.Entered into the directory /programs/witness_node and executed the command.Tried out specific tests as mentioned in the document and got error.

Screenshots
screenshot from 2018-08-30 18-28-04
screenshot from 2018-08-30 18-28-09
screenshot from 2018-08-30 18-30-23
screenshot from 2018-08-30 18-33-01
screenshot from 2018-08-30 18-48-00

@abitmore

This comment has been minimized.

Member

abitmore commented Aug 30, 2018

  1. The witness_node binary is inside programs/witness_node, you executed cd .. that's why you can't find it.
  2. We have tests/chain_test but not tests/chain_tests.
  3. I guess performance_test is outdated even if it still exists. The doc is somehow outdated as well.

@abitmore abitmore closed this Aug 30, 2018

@abitmore abitmore added the 0 Question label Aug 30, 2018

@sachushaji

This comment has been minimized.

sachushaji commented Aug 30, 2018

Then how can i check the througput? What tests should i follow?

@abitmore

This comment has been minimized.

Member

abitmore commented Aug 30, 2018

Then how can i check the throughput?

Good question. I don't have an answer. Perhaps others can help.

Perhaps run:

make performance_test
tests/performance_test

@abitmore abitmore reopened this Aug 30, 2018

@ryanRfox

This comment has been minimized.

Member

ryanRfox commented Aug 30, 2018

@sachushaji from the screen shots it seems you were able to get witness_node running and syncing toward 30M blocks. May I understand your intended test(s)? If it's related to transaction throughput, you may reference the stress test performed on the TESTNET in 2017: http://bitshares.kaufen/wp-content/uploads/docs/bitshares-stresstest.pdf

@sachushaji

This comment has been minimized.

sachushaji commented Aug 30, 2018

Hi @ryanRfox. I wanted to test it at my local machine to check whether it reaches the specified throughput level and verifiy it myself. Most of the popular projects enables this by specifying standard testing codes so as to verify the throughput, but I couldn't find any here. Can you shed some light into this issue?

@abitmore

This comment has been minimized.

Member

abitmore commented Aug 30, 2018

  • There is a typo in wiki and I've updated it.
  • I've checked the performance_test code,
    • sigcheck_benchmark works fine.
    • the commented out transfer_benchmark is trying to do 1M account creation and 1M transfers without generating one block, which IMHO is not a common scenario so doesn't make much sense.

@sachushaji IMHO so-called standard testing code is more for testing performance of running hardware but not the software.

@sachushaji

This comment has been minimized.

sachushaji commented Aug 30, 2018

I also want the same thing..with minimal hatdware spec whats the throughput and latency the network can achieve.

@abitmore : without generating blocks?

Sigcheck_benchmark is for private testnet throughput?

@sachushaji

This comment has been minimized.

sachushaji commented Aug 31, 2018

@abitmore I tried to run the performance tests as you mentioned but it gets an error
screenshot from 2018-08-31 12-54-33

@abitmore

This comment has been minimized.

Member

abitmore commented Aug 31, 2018

@sachushaji As I said that commented out test code doesn't make sense. If you want to try it, best if you can try to fix it by yourself and tell us the result of the test and submit a pull request. Thanks.

@sachushaji

This comment has been minimized.

sachushaji commented Aug 31, 2018

@abitmore okay, will try

@ryanRfox

This comment has been minimized.

Member

ryanRfox commented Sep 25, 2018

@pmconrad Did you post your 100k benchmark demo from your BitFest talk? Perhaps that will assist @sachushaji

@pmconrad

This comment has been minimized.

pmconrad commented Sep 26, 2018

See #1337

@oxarbitrage oxarbitrage added this to the 201810 - Feature Release milestone Sep 28, 2018

@abitmore abitmore added testing and removed 0 Question labels Sep 28, 2018

@abitmore abitmore added this to To do in Feature release (201810) via automation Sep 28, 2018

@abitmore abitmore moved this from To do to In progress in Feature release (201810) Sep 28, 2018

@abitmore

This comment has been minimized.

Member

abitmore commented Oct 9, 2018

Fixed by #1337.

@abitmore abitmore closed this Oct 9, 2018

Feature release (201810) automation moved this from In progress to Done Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment