New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably wrong comment #1301

Closed
botanegg opened this Issue Sep 1, 2018 · 7 comments

Comments

Projects
5 participants
@botanegg

botanegg commented Sep 1, 2018

Hello.
See at this line libraries/chain/db_update.cpp#L119

Are you sure about that comment?
I think is correct multiplier is .3, because GRAPHENE_IRREVERSIBLE_THRESHOLD is 70% of GRAPHENE_100_PERCENT

@abitmore

This comment has been minimized.

Member

abitmore commented Sep 1, 2018

There are lots of outdated comments in the code. If you're sure a comment is not correct, please submit a pull request. Thanks.

@ryanRfox

This comment has been minimized.

Member

ryanRfox commented Sep 4, 2018

Hi @botanegg and welcome. I'm the Coordinator for the Core Team. We encourage community members to assist us in identifying and resolving bugs, identifying features and enhancements, updating lacking documentation and drafting improvement proposals. Clearly, you are deep within the code, so please learn more here (see: Bounty Process). Also, I encourage your to review our Project Backlog for other open Issues you may be willing to claim.

@ryanRfox ryanRfox added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Sep 4, 2018

@ryanRfox ryanRfox moved this from New -Awaiting Core Team Evaluation to Unassigned - Features & Enhancements in Project Backlog Sep 4, 2018

@pmconrad

This comment has been minimized.

pmconrad commented Sep 5, 2018

The comment doesn't make much sense anyway because no two witnesses would have the same last_confirmed_block_num.

oxarbitrage added a commit that referenced this issue Sep 28, 2018

@oxarbitrage

This comment has been minimized.

Member

oxarbitrage commented Sep 28, 2018

i am not an expert in this subject but i think @botanegg is right here so i created #1349 to change the comment.

@oxarbitrage

This comment has been minimized.

Member

oxarbitrage commented Sep 28, 2018

other option can be to remove it fully but for ilustration purposes even as @pmconrad said this is not fully accurate i think we should keep.

@oxarbitrage oxarbitrage added this to the 201810 - Feature Release milestone Sep 29, 2018

@oxarbitrage

This comment has been minimized.

Member

oxarbitrage commented Sep 29, 2018

closed by #1349

@abitmore abitmore removed this from Unassigned - Features & Enhancements in Project Backlog Sep 29, 2018

@abitmore abitmore added this to To do in Feature release (201810) via automation Sep 29, 2018

@abitmore abitmore moved this from To do to Done in Feature release (201810) Sep 29, 2018

@botanegg

This comment has been minimized.

botanegg commented Oct 3, 2018

LOL, nice :)
thx 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment