Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate block production loop when shutting down witness plugin #1314

Closed
abitmore opened this issue Sep 9, 2018 · 9 comments

Comments

Projects
4 participants
@abitmore
Copy link
Member

commented Sep 9, 2018

Bug Description
Currently nothing is done when shutting down witness plugin. Actually we need to terminate the production loop, otherwise it often causes segfault.

void witness_plugin::plugin_shutdown()
{
// nothing to do
}

_block_production_task = fc::schedule([this]{block_production_loop();},
next_wakeup, "Witness Block Production");
}

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
    • Assigned: @cogutvalera
    • Estimate: 2 hours
    • Remittance: Core Team weeks 42-43
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Sep 9, 2018

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Sep 10, 2018

@ryanRfox I want to claim this issue.

Thanks !

@ryanRfox ryanRfox removed this from New -Awaiting Core Team Evaluation in Project Backlog Sep 10, 2018

@ryanRfox ryanRfox added the 6 UX label Sep 10, 2018

@ryanRfox

This comment has been minimized.

Copy link
Member

commented Sep 10, 2018

Assigned @cogutvalera to this issues, as he has done related work with the quit() routine. Please include an estimate so @bitshares/core-dev can review prior to beginning development. Thanks

@ryanRfox ryanRfox added this to In Development in Community Claims Sep 10, 2018

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Sep 11, 2018

@ryanRfox my estimation for this issue is approximately 2 hours

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Sep 17, 2018

@abitmore abitmore added this to To do in Feature release (201810) via automation Oct 1, 2018

@abitmore abitmore moved this from To do to In progress in Feature release (201810) Oct 1, 2018

cogutvalera added a commit to cogutvalera/bitshares-core that referenced this issue Oct 3, 2018

abitmore added a commit that referenced this issue Oct 8, 2018

Merge pull request #1332 from cogutvalera/issue_1314
Terminate block production loop when shutting down witness plugin #1314

Feature release (201810) automation moved this from In progress to Done Oct 8, 2018

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2018

Fixed by #1332.

@abitmore abitmore closed this Oct 8, 2018

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Oct 8, 2018

Thanks !

@pmconrad pmconrad reopened this Oct 10, 2018

Feature release (201810) automation moved this from Done to To do Oct 10, 2018

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2018

@cogutvalera I'm getting a compiler warning:

libraries/plugins/witness/witness.cpp: In member function ‘graphene::witness_plugin::block_production_condition::block_production_condition_enum graphene::witness_plugin::witness_plugin::block_production_loop()’:
libraries/plugins/witness/witness.cpp:214:10: warning: enumeration value ‘shutdown’ not handled in switch [-Wswitch]

Please fix.

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

Sure. Thanks !

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

PR #1364

pmconrad added a commit that referenced this issue Oct 12, 2018

Merge pull request #1364 from cogutvalera/issue_1314
Terminate block production loop when shutting down witness plugin #1314

@pmconrad pmconrad closed this Oct 12, 2018

Feature release (201810) automation moved this from To do to Done Oct 12, 2018

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Oct 12, 2018

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.