Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Test case failed on chain_test #1326
other tests except
CORE TEAM TASK LIST
I may be jumping in the middle here, but it is my understanding that this is testing to see if the isalpha function works as expected in various locales (new "non-C" way vs the classic "C" way).
What I do not understand is why are we testing a standard library function? Is there a belief that the standard will change? Or perhaps that some platforms will not implement it correctly?
Perhaps this test was simply to clarify how things work.
I may be wrong, but I do not see the benefit of those lines in this test. If everyone agrees, I will remove those lines. If not, please let me know why these lines are here. Thanks!
IIRC the asset name validation code used the system locale and thus might have allowed to create assets with non-ascii names, depending on witness system locale settings. This has been fixed, so IMO these lines can be removed.