Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitShares-fc compilation warnings #1383

Closed
cogutvalera opened this issue Oct 16, 2018 · 4 comments

Comments

Projects
4 participants
@cogutvalera
Copy link
Member

commented Oct 16, 2018

Instructions

  • Bug Description
  • Impacts
  • Steps To Reproduce
  • Expected Behavior
  • Host Environment (optional)
  • Additional Context (optional)

Bug Description
bitshares-fc compilation warning

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Steps To Reproduce
Steps to reproduce the behavior (example outlined below):

  1. cd bitshares-fc
  2. cmake .
  3. make
  4. See compile warnings

Expected Behavior
No compile warnings

Host Environment
Please provide details about the host environment. Much of this information can be found running: witness_node --version.

  • Host OS: Ubuntu 18.04 LTS
  • Host Physical RAM 16GB
  • Version: 2.0.171025-minor-fix-1-1418-g83b6fe20
  • SHA: 83b6fe2
  • SSL: OpenSSL 1.1.0g 2 Nov 2017
  • Boost: 1.65.1
  • Websocket++: 0.7.0

Additional Context (optional)

/home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/src/crypto/rand.cpp: In function ‘void fc::rand_pseudo_bytes(char*, int)’:
/home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/src/crypto/rand.cpp:24:60: warning: ‘int RAND_pseudo_bytes(unsigned char*, int)’ is deprecated[-Wdeprecated-declarations]
   int result = RAND_pseudo_bytes((unsigned char*)buf, count);
                                                            ^
In file included from /usr/include/openssl/e_os2.h:13:0,
                 from /usr/include/openssl/ossl_typ.h:19,
                 from /usr/include/openssl/rand.h:14,
                 from /home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/src/crypto/rand.cpp:1:
/usr/include/openssl/rand.h:47:1: note: declared here
 DEPRECATEDIN_1_1_0(int RAND_pseudo_bytes(unsigned char *buf, int num))
-------------------------------------------------------------------------------------------------------------------------------------
[ 45%] Building CXX object CMakeFiles/fc.dir/src/crypto/openssl.cpp.o
/home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/src/crypto/openssl.cpp: In constructor ‘fc::openssl_scope::openssl_scope()’:
/home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/src/crypto/openssl.cpp:33:33: warning: ‘void OPENSSL_config(const char*)’ is deprecated [-Wdeprecated-declarations]
           OPENSSL_config(nullptr);
                                 ^
In file included from /usr/include/openssl/evp.h:13:0,
                 from /home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/include/fc/crypto/openssl.hpp:4,
                 from /home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/src/crypto/openssl.cpp:1:
/usr/include/openssl/conf.h:92:1: note: declared here
 DEPRECATEDIN_1_1_0(void OPENSSL_config(const char *config_name))
 ^
[ 45%] Building CXX object CMakeFiles/fc.dir/src/crypto/aes.cpp.o
/home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/src/crypto/aes.cpp: In destructor ‘fc::openssl_thread_config::~openssl_thread_config()’:
/home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/src/crypto/aes.cpp:432:32: warning: the address of ‘static long unsigned int fc::openssl_thread_config::get_thread_id()’ will never be NULL [-Waddress]
   if (CRYPTO_get_id_callback() == &get_thread_id)
-------------------------------------------------------------------------------------------------------------------------------------

/home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/tests/crypto/rand_test.cpp: In function ‘void check_randomness(const char*, size_t)’:
/home/valera/Projects/Blockchain/Graphene/BitShares/bitshares-core/libraries/fc/tests/crypto/rand_test.cpp:23:12: warning: unused variable ‘sigma’ [-Wunused-variable]
     double sigma = sqrt(variance);

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2018

This is openssl-1.1. @cogutvalera please use our template for bug reports.

@cogutvalera

This comment has been minimized.

Copy link
Member Author

commented Oct 16, 2018

@pmconrad here I've posted 3 warnings, one of them is related to openssl

@cogutvalera

This comment has been minimized.

Copy link
Member Author

commented Oct 16, 2018

updated with bug reports template

@cogutvalera cogutvalera changed the title bitshares-fc compilation warnings BitShares-fc compilation warnings Oct 16, 2018

@jmjatlanta jmjatlanta self-assigned this Oct 23, 2018

@jmjatlanta

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

Fix in fc pull bitshares/bitshares-fc#84, although it did not squelch all warnings. One remains, left for good reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.