Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"PERLLIB=${CMAKE_CURRENT_SOURCE_DIR}" should be "PERLLIB=${CMAKE_CURRENT_BINARY_DIR}" #1418

Closed
z16166 opened this issue Nov 5, 2018 · 5 comments

Comments

@z16166
Copy link

commented Nov 5, 2018

The following line in libraries/wallet/CMakeLists.txt
PERLLIB=${CMAKE_CURRENT_SOURCE_DIR}
should be
PERLLIB=${CMAKE_CURRENT_BINARY_DIR}

otherwise the doxygen build will complain " Can't locate doxygen/perlmod/DoxyDocs.pm" in Ubuntu 18.04 TLS.

because the actual full path of DoxyDocs.pm is "BitShares/build/libraries/wallet/doxygen/perlmod/DoxyDocs.pm" if the cmake build dir is "BitShares/build".

@z16166

This comment has been minimized.

Copy link
Author

commented Nov 5, 2018

@jmjatlanta

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

I have attempted to replicate the issue and am unable. My environment is a little different (Ubuntu 18.10).

Could you please give me the steps to recreate the issue? Please also include the output from cmake. Thank you.

Additional info: I tried with and without the suggested change to the PERLLIB line in libraries/wallet/CMakeLists.txt, and both worked fine. Change is in the jmj_1418 branch, awaiting problem verification before a PR is created.

@abitmore

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

@jmjatlanta have you tried out-of-source build?

mkdir build
cd build
cmake ..
make
@jmjatlanta

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

@jmjatlanta have you tried out-of-source build?

Just tried. Still works for me (unfortunately).

Update I tried it with a fresh clone of the codebase, and out-of-source build, and it failed. Evidently I was not cleaning my environment totally.

@jmjatlanta jmjatlanta moved this from To do to In progress in Feature Release (201902) Jan 25, 2019

oxarbitrage added a commit that referenced this issue Jan 25, 2019

Merge pull request #1539 from bitshares/jmj_1418
Fixes #1418 - Fix CMake Doxygen Perl reference
@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

closed by #1539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.