Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
get_key_references performance issue? #1472
bitshares/bitshares-ui#2367 is related.
The result can still be too large, E.G. containing thousands of accounts, thus can be problematic.
CORE TEAM TASK LIST
Are you worried about the performance of querying for all of them? Or are you worried about the performance of all those subscriptions? Or both?
If we limit the subscriptions, how would we communicate to the user that may be expecting us to subscribe to all of them?
I would be surprised if that works, as you are subscribing to a vector, and not individual accounts. Is there some magic happening here, or is my surprise warranted?
referenced this issue
Dec 27, 2018
thing is, UI still does a get_full_accounts on them after received...so it effectively/eventually does subscribe to all of them.
we've had a discussion on UI group about this and it seems this will need some major refactoring (to fix other performance issues as well)