Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart_ref causes build issues #1548

Closed
jmjatlanta opened this issue Jan 31, 2019 · 1 comment

Comments

Projects
3 participants
@jmjatlanta
Copy link
Contributor

commented Jan 31, 2019

Some platforms are very picky about including headers. That is fine. But there is one header that constantly needs to be added, and it seems to be fairly needless...

fc::smart_ref, as its name implies, attempts to be a "smart reference". It is used in only 1 area of Bitshares, having to do with the collection of fee parameters. Due to the design, each user of fee parameters (many) must also include the smart_ref header, otherwise certain platforms (esp. macOS) will not compile.

There have been many pull requests and issues to add this header to various files to complete compilation on various platforms. This issue is to find and implement a viable replacement with less hastle.

Related: #1547 (comment)
and: #1516 (comment)

Steps To Reproduce
On macOS, follow the normal steps to compile the current master branch. The compilation will fail due to smart_ref.

CORE TEAM TASK LIST

  • Evaluate Build Error
  • Provide build guidance
  • Create Bug Report
@jmjatlanta

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

Fixed by PR #1556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.