Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check transaction size #1573

Closed
abitmore opened this issue Feb 12, 2019 · 8 comments

Comments

Projects
5 participants
@abitmore
Copy link
Member

commented Feb 12, 2019

Bug Description
As reported in #374, transaction size hasn't been checked in consensus code, although we have a global chain parameter maximum_transaction_size.

uint32_t maximum_transaction_size = GRAPHENE_DEFAULT_MAX_TRANSACTION_SIZE; ///< maximum allowable size in bytes for a transaction

Note: before enabling this check with a hard fork, we should set the parameter to a fair value to avoid breaking things.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@jmjatlanta

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

GRAPHENE_DEFAULT_MAX_TRANSACTION_SIZE is set to 2048, which I believe is way too low. So I agree with Abit. The maximum_transaction_size should be adjusted prior to the hardfork.

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

What is the biggest transaction we had in mainnet so far?

@jmjatlanta

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

I will be doing a reindex tonight. I will attempt to capture that information.

@abitmore abitmore moved this from To Do to In Development in Protocol Upgrade Release (3.0.0) Feb 16, 2019

@jmjatlanta

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

Fixed by #1586 Biggest transaction to date: 1,008,285

@jmjatlanta jmjatlanta closed this Feb 22, 2019

Protocol Upgrade Release (3.0.0) automation moved this from In Development to Done Feb 22, 2019

@xeroc

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

I'll propose to committee to set a max tx size of 1,024,000

@clockworkgr

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

I'll propose to committee to set a max tx size of 1,024,000

1,048,576 please...let's not mix SI and IEC prefixes :)

@jmjatlanta

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

The best thing about standards is there are so many to choose from. I vote for 1,010,101 as it looks more "techie" :-D

@clockworkgr

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

1234567 ? easy to remember

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.