Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"plugins" option in config.ini is ignored #1637

Closed
abitmore opened this issue Mar 7, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@abitmore
Copy link
Member

commented Mar 7, 2019

Bug Description

  • when generating a new config.ini, there is no longer a "plugins" option inside;
  • "plugins" option specified in config.ini is ignored.

Mentioned in #1083 (comment) earlier.

Version 2.0.190219 and 2.0.190305 are impacted.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

Possibly cause by #1437
@oxarbitrage can you check?

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

yes ill check it today.

@oxarbitrage oxarbitrage self-assigned this Mar 7, 2019

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

It seems we have 2 options to go over this:

1- Add something like:

      cfg_options.add_options()
              ("plugins", bpo::value<std::string>()->default_value(options.at("plugins").as<std::string>()),
               "Space-separated list of plugins to activate");         

In the binary. The problem with this is that it will end having the plugins option in the top or at the bottom of the config file.

2- Add to application.cpp in the spot we want at: https://github.com/bitshares/bitshares-core/blob/master/libraries/app/application.cpp#L955
Problem here is that we will need the default plugins to be added in 2 places(application and binary) and that is one of the things we were trying to avoid at #1437

Suggestions are welcome, ill keep researching.

@xeroc

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Dang, this issue took me almost 2 hours today until I figured out plugins is no longer read from config.ini .. Glad you have this covered already!

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

fixed by #1647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.