Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fail_reason to reflection meta #1730

Closed
dot5enko opened this issue Apr 22, 2019 · 2 comments

Comments

Projects
2 participants
@dot5enko
Copy link

commented Apr 22, 2019

Bug Description
fail_reason field of proposal_object is not added to proposal_object.hpp FC_REFLECT_DERIVED meta so RPC get_object results lacks that info

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Ouch. Thanks.
This should be fixed in the upcoming feature release.

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Fixed by #1732

@pmconrad pmconrad closed this Apr 25, 2019

Feature Release (3.1.0) automation moved this from In development to Done Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.