Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total backing asset for Backed Assets #1781

Closed
startailcoon opened this issue May 28, 2019 · 6 comments

Comments

@startailcoon
Copy link

commented May 28, 2019

A backed asset, like bitUSD, is backed by another asset, in this case BTS.
At the moment it's not an easy task to calculate the amount of total backing asset for the backed asset.

The UI requests a calculation of this for easy usage without having to do all the calculations manually.

See issue bitshares/bitshares-ui#2715 for more details.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context (optional)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation May 28, 2019

@abitmore abitmore added this to the Future Feature Release milestone May 28, 2019

@abitmore

This comment has been minimized.

Copy link
Member

commented May 28, 2019

#1089 is related.

@abitmore

This comment has been minimized.

Copy link
Member

commented May 28, 2019

My idea for this feature is to add a secondary index to call_order_index in a plugin, just like grouped_orders plugin.

Pros:

  • it won't affect performance of nodes which doesn't enable the plugin

Cons:

  • change of data in secondary index doesn't trigger notifications with current subscription-notification mechanism.
@pmconrad

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

#1089 is related.

IMO it's more than related, it's a duplicate. Can close either this or the other one. Or did I miss something?

@abitmore

This comment has been minimized.

Copy link
Member

commented May 28, 2019

#1089 and this issue are slightly different. This issue is for debt asset info page, #1089 is for collateral asset info page.

@pmconrad pmconrad removed this from New -Awaiting Core Team Evaluation in Project Backlog Jun 25, 2019

@pmconrad pmconrad added this to To do in Feature Release (3.3.0) via automation Jun 25, 2019

@pmconrad pmconrad self-assigned this Jun 27, 2019

@pmconrad pmconrad moved this from To do to In development in Feature Release (3.3.0) Jun 27, 2019

pmconrad added a commit to pmconrad/bitshares-core that referenced this issue Jun 29, 2019

@ryanRfox ryanRfox moved this from In development to In testing in Feature Release (3.3.0) Jul 16, 2019

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Merged #1836 - please keep this open until release notes are created. Public API nodes should activate the new plugin when upgrading.

@jmjatlanta jmjatlanta moved this from In testing to Done in Feature Release (3.3.0) Aug 7, 2019

manikey123 added a commit to manikey123/bitshares-core that referenced this issue Aug 12, 2019
@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Upgrade instructions are now mentioned in the release notes.

@pmconrad pmconrad closed this Aug 14, 2019

jmjatlanta added a commit that referenced this issue Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.