Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional auto-subscription parameters to APIs #1819

Closed
abitmore opened this issue Jun 21, 2019 · 1 comment

Comments

@abitmore
Copy link
Member

commented Jun 21, 2019

User Story
These APIs may auto-subscribe to querying objects:

  • get_accounts(vector)
  • get_assets(vector)
  • get_objects(vector)
  • lookup_accounts(string, uint32_t)

The BitShares UI team wants to be able to opt-out auto-subscription for all these APIs, just like the behavior of get_full_accounts API (bitshares/bitshares-ui#2612).

Since bitshares-core now supports optional parameters for API calls (bitshares/bitshares-fc#126), the feature can be implemented by adding an optional parameter to the APIs without break existing client applications.

Originally discussed in #777. Part of #1766.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • UX (the User Experience)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation

@abitmore abitmore added this to To do in Feature Release (3.3.0) via automation Jun 21, 2019

@abitmore abitmore added this to the 3.3.0 - Feature Release milestone Jun 21, 2019

@abitmore abitmore referenced this issue Jun 21, 2019
4 of 9 tasks complete

@ryanRfox ryanRfox added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Jul 16, 2019

@ryanRfox ryanRfox removed this from To do in Feature Release (3.3.0) Jul 16, 2019

@abitmore abitmore self-assigned this Jul 23, 2019

@abitmore abitmore added this to To do in Feature Release (3.3.0) via automation Jul 23, 2019

@abitmore abitmore removed this from New -Awaiting Core Team Evaluation in Project Backlog Jul 23, 2019

@abitmore abitmore moved this from To do to In development in Feature Release (3.3.0) Jul 23, 2019

@jmjatlanta jmjatlanta added this to To do in Feature Release (4.1.0) via automation Aug 7, 2019

@jmjatlanta jmjatlanta removed this from In development in Feature Release (3.3.0) Aug 7, 2019

@abitmore abitmore removed this from To do in Feature Release (4.1.0) Aug 9, 2019

@abitmore abitmore added this to To do in Feature Release (3.3.0) via automation Aug 9, 2019

@abitmore abitmore moved this from To do to In testing in Feature Release (3.3.0) Aug 9, 2019

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Closed by #1868

Documentation may be needed somewhere but not mandatory as commands involved will keep working as before.

Feature Release (3.3.0) automation moved this from In testing to Done Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.