New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset creation fee issue #433
Comments
Is there an ETA? crypto-bridge is already complaining, since they rely on creating assets |
Yes, an ETA would be good. This is already damaging to us as we have clients already asking us what's up and why their coins can't be added to the exchange. Thanks. |
Resolved conflicts: libraries/chain/asset_evaluator.cpp
@btsfav @CryptoBridge when majority of witnesses has applied the soft fork, the committee can reduce the fee. Hopefully will be done in 24 hours. |
Should be fixed in release |
This reverts commit 41b2f31 (except the test case).
When creating an asset, if the fee is not paid in the CORE asset but in another asset, an amount of extra CORE asset will be created from nowhere unexpectedly.
The workflow is
prepare_fee
->do_evaluate
->convert_fee
->pay_fee
->do_apply
.prepare_fee
is in evaluator.cpp,core_fee_paid
got initialized normally:do_evaluate
is in asset_evaluator.cpp,core_fee_paid
is halved:convert_fee
is in evaluator.cpp, the halvedcore_fee_paid
is deducted from the fee paying asset's fee pool (this is incorrect, instead, we should deduct full amount from the fee pool):pay_fee
is in evaluator.cpp, the halvedcore_fee_paid
is sent to referral program:do_appy
is in asset_evaluator.cpp, the halvedcore_fee_paid
got added to the new asset's fee pool**:A soft fork is proposed to prevent this issue from being exploited: #432.
The text was updated successfully, but these errors were encountered: