Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owner keys of non-immediately required accounts can not authorize a transaction #584

Closed
abitmore opened this issue Jan 17, 2018 · 1 comment

Comments

Projects
2 participants
@abitmore
Copy link
Member

commented Jan 17, 2018

@pmconrad found the misbehavior here, quoted below:

..., if the general rule is that owner can always sign in place of active, then the recursion in sign_state::check_authority must also check for the owner auth (https://github.com/abitmore/bitshares-core/blob/97fe7208e62ef710ed16badd2404d738851965fd/libraries/chain/protocol/transaction.cpp#L199).

Say, if an account A's active authorities is

{
  "threshold": 1,
  "account_auths": [ "ID_of_account_B", 1 ],
  ...
}

then a transaction which requires account A's active authorities but only signed with account B's owner key should be accepted by the chain.

@abitmore abitmore added the hardfork label Jan 17, 2018

@abitmore abitmore added this to the Future Consensus-Changing Release milestone Jan 17, 2018

@abitmore abitmore added bug and removed bug labels Jan 17, 2018

abitmore added a commit to abitmore/bitshares-core that referenced this issue Jan 18, 2018

abitmore added a commit to abitmore/bitshares-core that referenced this issue Jan 18, 2018

@abitmore abitmore added the bug label Feb 5, 2018

@abitmore abitmore self-assigned this Aug 14, 2018

@abitmore abitmore added this to In Development in Protocol Upgrade Release (3.0.0) Sep 13, 2018

@pmconrad pmconrad moved this from In Development to In Testing in Protocol Upgrade Release (3.0.0) Jan 30, 2019

pmconrad added a commit that referenced this issue Feb 10, 2019

Merge pull request #1259 from bitshares/584-non-immediate-owner
Fix #584 authorize transactions with non-immediate owner authorities
@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

closed by #1259

Protocol Upgrade Release (3.0.0) automation moved this from In Review to Done Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.