Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand `get_top_markets` API to return more data fields #842

Closed
abitmore opened this issue Apr 13, 2018 · 2 comments

Comments

Projects
3 participants
@abitmore
Copy link
Member

commented Apr 13, 2018

Expand get_top_markets API to return more data fields, specifically, the fields returned by get_ticker API. Or create a new API to return vector<market_ticker>.

Other than that, we still need to think how to improve the APIs to avoid being spammed / manipulated, as discussed here: #560 (comment).

Please discuss.

@abitmore abitmore added this to the Future Non-Consensus-Changing Release milestone Apr 13, 2018

@ryanRfox ryanRfox added this to To Do in Feature Release (201808) via automation May 24, 2018

@ryanRfox ryanRfox moved this from To Do to Done in Feature Release (201808) May 24, 2018

@ryanRfox ryanRfox moved this from Done to In Development in Feature Release (201808) Jun 14, 2018

@abitmore abitmore removed this from In Development in Feature Release (201808) Jul 21, 2018

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Jul 21, 2018

@abitmore abitmore removed this from New -Awaiting Core Team Evaluation in Project Backlog Jul 29, 2018

@abitmore abitmore added this to To do in Feature release (201810) via automation Jul 29, 2018

@abitmore abitmore moved this from To do to In progress in Feature release (201810) Jul 29, 2018

@abitmore abitmore removed this from In progress in Feature release (201810) Sep 14, 2018

@abitmore abitmore added this to To do in Feature Release (201902) via automation Sep 14, 2018

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Feb 1, 2019

There were some (maybe useful) comments in #924.

#924 (comment) by @jhtitor:

I have 2 cents from bitshares-qt standpoint.

First of all, the get_top_markets API itself is a great idea, and I'm really glad we finally have such a feature. Going to use it extensively.

Secondly, I think it would be great, if the API could be expanded to allow setting base asset. Say, a user is interested in trading OPEN.BTC -- I want to show top OPEN.BTC markets. The current behavior (listing everything) is also extremely useful, so I'm not proposing to replace it.

Sorry if this is the wrong ticket, which only deals with the return format.

#924 (comment) by me:

I too want to leave something here for reference, but don't want to write a feature request yet:

oxarbitrage added a commit that referenced this issue Feb 5, 2019

Merge pull request #1549 from oxarbitrage/issue842_2
refactor get_top_markets issue #842
@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

closed by #1549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.