Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI command to add signatures to a partially signed transaction #867

Closed
abitmore opened this issue Apr 21, 2018 · 11 comments

Comments

Projects
4 participants
@abitmore
Copy link
Member

commented Apr 21, 2018

Having a way to add signatures to a partially signed transaction, is useful for off-chain multi-signing and cold storage.

As mentioned in #865, current sign_transaction command will clear all existing signatures before adding new ones, but we don't want to change the behavior, so it's better to add a new one.

Note: if modified expiration and / or TaPoS fileds, the old signatures will become invalid, so can't change them as well.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
    • Assigned: @cifer-lee
    • Estimated: 15 hours (10 AUG: revision required based on refactoring effort, see #1032)
  • Perform QA/Testing
  • Update Documentation

@abitmore abitmore added this to the Future Non-Consensus-Changing Release milestone Apr 21, 2018

@ryanRfox ryanRfox self-assigned this May 21, 2018

@cifer-lee

This comment has been minimized.

Copy link
Member

commented May 21, 2018

Claiming this Issue. Will begin work now. Coordinating with @ryanRfox for updates.

@ryanRfox ryanRfox added this to New -Awaiting Core Team Evaluation in Project Backlog via automation May 21, 2018

@ryanRfox ryanRfox added this to In Development in Community Claims May 21, 2018

@ryanRfox ryanRfox removed this from New -Awaiting Core Team Evaluation in Project Backlog May 21, 2018

cifer-lee added a commit to cifer-lee/bitshares-core that referenced this issue May 30, 2018

@cifer-lee

This comment has been minimized.

Copy link
Member

commented May 31, 2018

Need more discussing with this issue. How the multi-sig procedures be implemented and how these to-be-added cli command(s) will be used.

Follow's my thoughts about multi-sig solution:

  1. Create a initial transaction, with TaPoS and expiration field assigned. This can be performed on either online or offline machine. When on a offline machine, TaPoS field can be specified manually.
  2. Export the initial transaction and import it to offline machine (cold wallet)
  3. The initial transaction may or may not taken signatures, up to whether or not signed it in step 1. Anyway, we can sign this transaction using the offline-stored key directly. (Not query required authorities/signatures through api since the offline machine not synced)
  4. Export the signed transaction from offline machine and repeat step 3
  5. Import the final transaction into a online machine and broadcast it

Willing to hear from other devs..

cifer-lee added a commit to cifer-lee/bitshares-core that referenced this issue Jun 7, 2018

@ryanRfox ryanRfox moved this from In Development to In Testing in Community Claims Jun 7, 2018

@ryanRfox ryanRfox moved this from In Testing to In Development in Community Claims Jun 8, 2018

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Jul 21, 2018

does anybody work on this issue or can I claim it in order to finish ?

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Jul 21, 2018

I want to claim this issue, is it possible ? Thanks !

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Jul 21, 2018

the work is still in progress on this issue or not ?

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2018

@cogutvalera this issue has been claimed by @cifer-lee, work in progress.

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Jul 21, 2018

ok sure ! Thank you very much for the info ! Because I couldn't understand if work is in progress or not.

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2018

The work in progress pull request is #1032.

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Jul 22, 2018

Yes, understood ! Thanks ! Sorry for misunderstanding, just time confused me and I thought this issue was stopped/paused in development.

cifer-lee added a commit to cifer-lee/bitshares-core that referenced this issue Jul 23, 2018

@abitmore abitmore added this to To do in Feature release (201810) via automation Jul 29, 2018

@abitmore abitmore moved this from To do to In progress in Feature release (201810) Jul 29, 2018

@ryanRfox ryanRfox assigned cifer-lee and unassigned ryanRfox Aug 10, 2018

@ryanRfox ryanRfox added 2f Testing and removed 2d Developing labels Aug 10, 2018

@ryanRfox ryanRfox moved this from In Development to In Testing in Community Claims Aug 10, 2018

@abitmore abitmore removed this from In progress in Feature release (201810) Sep 13, 2018

@abitmore abitmore added this to To do in Feature Release (201902) via automation Sep 13, 2018

@abitmore abitmore moved this from To do to In progress in Feature Release (201902) Oct 9, 2018

@ryanRfox ryanRfox added this to To do in Feature Release (3.1.0) via automation Feb 5, 2019

@ryanRfox ryanRfox removed this from In progress in Feature Release (201902) Feb 5, 2019

@ryanRfox

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

Removing from 201902, adding to (next) Feature Release.

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

Fixed by #1032.

@abitmore abitmore closed this Mar 13, 2019

Feature Release (3.1.0) automation moved this from In development to Done Mar 13, 2019

@pmconrad pmconrad removed this from In Testing in Community Claims Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.